test/2.1: Add comprehensive streaming tests for audiobook controller#117
Merged
Conversation
- Add test for raw binary response (not base64) - Add test for correct MIME type headers (audio/mp4, audio/mpeg) - Add test for Range request support (206 status + Content-Range header) - Add test for Accept-Ranges header - Add test for 416 status on unsatisfiable range Verifies the fix from commit 998c795 (streamAudiobook raw bytes + Range support)
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 4 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive tests to verify the audiobook streaming fix from commit 998c795.
Tests Added
streamAudiobook()returns raw bytes, not base64-encoded dataaudio/mp4for .m4b andaudio/mpegfor .mp3 filesContent-RangeheaderAccept-Ranges: bytesheader is setVerification
Related
Fixes section 2.1 of the Phlix update tracker.