Fixed issue 89 - a lamp line beginning with a # but without a space was#90
Open
craigwarner-ufastro wants to merge 1 commit into
Open
Fixed issue 89 - a lamp line beginning with a # but without a space was#90craigwarner-ufastro wants to merge 1 commit into
craigwarner-ufastro wants to merge 1 commit into
Conversation
not omitted as it should be. Now both '#ArI...' and '# ArI...' as well as ' # ArI...' will all be treated as comments.
There was a problem hiding this comment.
Pull request overview
This PR fixes Specex lamp line list parsing so that lines starting with # are always treated as comments (including #ArI... without a space), preventing accidentally including commented-out lamp lines in the fit (fixes issue #89).
Changes:
- Skip empty/whitespace-only lines before attempting to parse them.
- Skip lines whose first non-whitespace character is
#before parsing tokens.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not omitted as it should be. Now both
'#ArI...'
and
'# ArI...'
as well as
' # ArI...'
will all be treated as comments.
This fixes #89