Repository navigation
Link the Decimal object documentation from the main navigation - #18
Merged
Merged
Conversation
The only pointer to the value object's own documentation was the last line of the conversion reference. Arithmetic, rounding and comparison all live in php-collective/decimal-object, so readers looking for those had no visible way to get there. Adds the link to the top navigation, the sidebar, the home page feature card and a tip box in Getting started, and points the existing links at the new documentation site.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (5)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only pointer to the
Decimalobject's own documentation was the last line of the Conversion reference page. Arithmetic, rounding and comparison are all documented upstream, so that link deserves a visible place.Draft until php-collective/decimal-object#22 is merged and GitHub Pages is enabled there. Until then https://php-collective.github.io/decimal-object/ returns 404.