Fix TOML rendering crash on float config values - #116
Merged
Conversation
_render_toml_value handled bool/int/str/list but not float, so rendering the commented default template crashed on the 0.3 temperature default. Add a float branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pyagent-config initcrashed withTypeError: unsupported toml value: 0.3:_render_toml_valuehandledbool,int,str, andlist, but notfloat— so rendering the commented default template blew up on the0.3temperature default inDEFAULTS.Fix
Add a
floatbranch to_render_toml_valuethat emitsrepr(v).Test plan
pyagent-config init --forcesucceeds and writes the default config + seeds roles