This repository was archived by the owner on Dec 3, 2023. It is now read-only.
Improve ConfigLoader::PHP_CONST_REGEX#4484
Merged
TomasVotruba merged 1 commit intodeprecated-packages:mainfrom Nov 25, 2022
Merged
Improve ConfigLoader::PHP_CONST_REGEX#4484TomasVotruba merged 1 commit intodeprecated-packages:mainfrom
TomasVotruba merged 1 commit intodeprecated-packages:mainfrom
Conversation
Member
|
Thank you 👏 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation from #4441 🙂
Differences between proposed regex and actual change in the PR:
\\in first group I had to do\\\\because somehow tests were failing: class' FQCN was not properly caught and was causing syntax issues, e.g.:Regex URL was updated, but currently it does not contain
\\\\change (works without it).