Conversation
… list form The previous list-form implementation built each node's result by iterating over every child's full transitive Set and re-adding items into the parent Set. For K files sharing a common package with M transitive deps this cost O(K*M) Set.add calls, and the spread push(...subTree) over a large Set risked a RangeError on very deep trees. The new traverseList / traverseListHelper pair does a single post-order DFS with one seen Set for cycle/duplicate detection, visiting each file exactly once and pushing it to the result array after its children - O(N) in unique files with identical output order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous list-form implementation built each node's result by iterating over every child's full transitive Set and re-adding items into the parent Set. For K files sharing a common package with M transitive deps this cost O(K*M) Set.add calls, and the spread push(...subTree) over a large Set risked a RangeError on very deep trees.
The new traverseList / traverseListHelper pair does a single post-order DFS with one seen Set for cycle/duplicate detection, visiting each file exactly once and pushing it to the result array after its children - O(N) in unique files with identical output order.