AdminConsole:ラベルが表示されない箇所が複数存在する#2056
Open
h-terazaki wants to merge 6 commits into
Open
Conversation
locale_xxx.jsに抜けていたキーを追加
Contributor
There was a problem hiding this comment.
Pull request overview
本PRは、@MetaFieldInfo の displayNameKey / descriptionKey に対応するロケールキーが locale_ja.js / locale_en.js に存在せず、画面上でメッセージが空表示になる問題(#2040)を解消するため、不足していたキー定義を追加するものです。
Changes:
locale_ja.jsに不足していた表示名/説明用のロケールキーを追加locale_en.jsに不足していた表示名/説明用のロケールキーを追加
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| iplass-admin/src/main/resources/org/iplass/adminconsole/public/locale/locale_ja.js | 画面で空表示になっていた項目向けのロケールキー(日本語)を追加 |
| iplass-admin/src/main/resources/org/iplass/adminconsole/public/locale/locale_en.js | 画面で空表示になっていた項目向けのロケールキー(英語)を追加 |
指摘修正
誤字の修正 検索性のためキーの配置を修正
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 3 changed files in this pull request and generated no new comments.
Files not reviewed (2)
- iplass-admin/src/main/resources/org/iplass/adminconsole/public/locale/locale_en.js: Language not supported
- iplass-admin/src/main/resources/org/iplass/adminconsole/public/locale/locale_ja.js: Language not supported
yuichi-github
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
対応内容
locale_xxx.jsに抜けていたキーを追加
closes #2040
動作確認・スクリーンショット(任意)
レビュー観点・補足情報(任意)