Skip to content

AdminConsole:ラベルが表示されない箇所が複数存在する#2056

Open
h-terazaki wants to merge 6 commits into
masterfrom
feature/2040-locale-message
Open

AdminConsole:ラベルが表示されない箇所が複数存在する#2056
h-terazaki wants to merge 6 commits into
masterfrom
feature/2040-locale-message

Conversation

@h-terazaki
Copy link
Copy Markdown
Contributor

対応内容

locale_xxx.jsに抜けていたキーを追加
closes #2040

動作確認・スクリーンショット(任意)

レビュー観点・補足情報(任意)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

本PRは、@MetaFieldInfodisplayNameKey / descriptionKey に対応するロケールキーが locale_ja.js / locale_en.js に存在せず、画面上でメッセージが空表示になる問題(#2040)を解消するため、不足していたキー定義を追加するものです。

Changes:

  • locale_ja.js に不足していた表示名/説明用のロケールキーを追加
  • locale_en.js に不足していた表示名/説明用のロケールキーを追加

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
iplass-admin/src/main/resources/org/iplass/adminconsole/public/locale/locale_ja.js 画面で空表示になっていた項目向けのロケールキー(日本語)を追加
iplass-admin/src/main/resources/org/iplass/adminconsole/public/locale/locale_en.js 画面で空表示になっていた項目向けのロケールキー(英語)を追加

2箇所漏れていた箇所を修正
セミコロンの漏れ修正
スペルミスの修正
TODOのコメントアウトを削除
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

誤字の修正
検索性のためキーの配置を修正
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 3 changed files in this pull request and generated no new comments.

Files not reviewed (2)
  • iplass-admin/src/main/resources/org/iplass/adminconsole/public/locale/locale_en.js: Language not supported
  • iplass-admin/src/main/resources/org/iplass/adminconsole/public/locale/locale_ja.js: Language not supported

@h-terazaki h-terazaki changed the title ローカライズ: メッセージが空になる箇所が複数存在する AdminConsole:ラベルが表示されない箇所が複数存在する May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AdminConsole:ラベルが表示されない箇所が複数存在する

3 participants