Skip to content

Fix limit resetting with lookback when all fetched incidents were dupes#43746

Draft
itssapir wants to merge 3 commits intomasterfrom
ServiceNowFixLookback
Draft

Fix limit resetting with lookback when all fetched incidents were dupes#43746
itssapir wants to merge 3 commits intomasterfrom
ServiceNowFixLookback

Conversation

@itssapir
Copy link
Copy Markdown
Contributor

@itssapir itssapir commented Mar 30, 2026

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: XSUP-66069

Description

The look back feature resets the limit when no new incidents were fetched, even if there are still cached incident IDs, causing subsequent fetches to use a low limit, creating an endless loop of fetching only duplicates and no new incidents.

Must have

  • Tests
  • Documentation

@content-bot
Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 30, 2026

Coverage

Tests Skipped Failures Errors Time
5833 89 💤 8 ❌ 0 🔥 27523491m 30s ⏱️

@content-bot
Copy link
Copy Markdown
Contributor

⚠️ The PR is missing the ready-for-pipeline-running label. Please add the label when the PR is ready in order to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants