DLPX-98314 delphix-kernel: control.{aws,generic}.in still Depend on linux-modules-extra, which Ubuntu dropped for those flavors in 7.0 - #22
Merged
lyriclake merged 1 commit intoAug 10, 2026
Conversation
lyriclake
force-pushed
the
dlpx/pr/lyriclake/ae112670-d074-47e7-9b37-079752445050
branch
from
August 5, 2026 20:39
301c20e to
fe74868
Compare
lyriclake
marked this pull request as ready for review
August 5, 2026 20:54
david-mendez1
left a comment
There was a problem hiding this comment.
Looks fine, depending on ab-pre-push
david-mendez1
approved these changes
Aug 5, 2026
dbjwhs-perforce
approved these changes
Aug 5, 2026
dbjwhs-perforce
left a comment
There was a problem hiding this comment.
LGTM, I see something like this was almost done back in the day PR 20
Contributor
Author
Testing status updateab-pre-push build #14734: compile stage SUCCESS
This fix is confirmed working; no further action needed on this PR pending review. |
Contributor
Author
Test stage final update
Compile stage remains confirmed SUCCESS ( |
…inux-modules-extra, which Ubuntu dropped for those flavors in 7.0
lyriclake
force-pushed
the
dlpx/pr/lyriclake/ae112670-d074-47e7-9b37-079752445050
branch
from
August 10, 2026 19:20
fe74868 to
9258442
Compare
lyriclake
enabled auto-merge
August 10, 2026 19:24
lyriclake
deleted the
dlpx/pr/lyriclake/ae112670-d074-47e7-9b37-079752445050
branch
August 10, 2026 19:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
appliance-build fails to install the appliance image once a flavor's Ubuntu base drops the
linux-modules-extrapackage split for that kernel line:Both are the same fleet-wide Canonical initiative (Launchpad #2042831) dropping the modules-extra split flavor by flavor. Each time it lands for a flavor, that flavor's
debian.<flavor>/control.d/flavour-control.stubloses itslinux-modules-extra-PKGVER-ABINUM-FLAVOURstanza andrules.d/amd64.mkstops settingdo_extras_package = true— but this repo'sdebian/control.<flavor>.inkeeps hard-declaringDepends: linux-modules-extra-@@KVERS@@, so apt can never satisfy it once that flavor's base drops the split.This PR originally only touched
control.aws.in, on the reasoning that other flavors' bases still shipped the split — true when opened (2026-08-05), but no longer true for generic once linux-kernel-generic#57 landed on 2026-08-07 (DLPX-98407, folded into DLPX-98314).Solution
Remove
linux-modules-extra-@@KVERS@@from theDepends:list indebian/control.aws.inanddebian/control.generic.in.control.oracle.in,control.gcp.in, andcontrol.azure.inare intentionally left untouched — those flavors' Ubuntu bases still ship the modules-extra split today. Removing the dependency preemptively for those flavors would be a silent functional regression, since apt would simply stop requiring a package that still exists rather than erroring, so driver/module content would quietly stop being installed by default until something broke in the field. Each other flavor should get this same treatment only once its own base tag actually drops the split.Testing Done
aws: Validated with
git ab-pre-pushusing--extra-repoto combine this fix branch with the linux-kernel-aws#72 patchset and the zfs sockaddr_unsized fix (delphix/zfs#2305, DLPX-98297), rerunning the full appliance-build-orchestrator-pre-push (build #14734,PLATFORMS=aws). Compile stage SUCCESS (appliance-build » pre-push #7165). Test stage:upgrade-testing #4621→blackbox-chained #9578: FAILURE, 2/49 failures — an SSH connectivity timeout mid-upgrade (test_upgrade_linux_system), matching a known unresolved infra flake (DLPXQA-53392) rather than a regression from this fix or the rebase.generic: the
control.generic.inchange is new to this PR (added for DLPX-98407) and has not yet had its own combinedab-pre-pushrun with the linux-kernel-generic#57 patchset — will add that result here before merge. Note the earlier "generic: UNSTABLE, 0/97" result recorded against this PR was from linux-kernel-generic#57's own standalone pre-push run, which did not include this delphix-kernel branch (build #14734 above only builtPLATFORMS=aws) — it doesn't validate the generic fix in this PR.