Skip to content

fix: apply PRs #7500, #7499, #7491 - #1

Open
deepshekhardas wants to merge 1 commit into
mainfrom
fix-7500-7499-7491-v2
Open

fix: apply PRs #7500, #7499, #7491#1
deepshekhardas wants to merge 1 commit into
mainfrom
fix-7500-7499-7491-v2

Conversation

@deepshekhardas

@deepshekhardas deepshekhardas commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Three fixes from refinedev/refine:


Summary by cubic

Fixes three issues: safely decodes malformed route params to prevent crashes, prevents cached show-page data from overriding create form defaults, and adds tooltips for truncated menu labels in the collapsed sider.

  • Bug Fixes
    • Routing: Safely decode id and to params in @refinedev/core, @refinedev/react-router, and @refinedev/remix-router to avoid errors on malformed URI components.
    • Forms: In @refinedev/refine-core, useForm stops passing id for create actions to prevent useOne cache collisions; in @refinedev/refine-react-hook-form, useModalForm avoids resetting defaults on create.
    • UI: In @refinedev/antd, ThemedSider shows tooltips for truncated menu labels (including Logout) when collapsed.

Written for commit 0e6d1b5. Summary will update on new commits.

Review in cubic

- fix: safe decode malformed URI route params (refinedev#7500)
- fix(core): prevent cached show page data in create forms (refinedev#7499)
- fix(antd): add tooltip support for truncated menu labels in ThemedSider (refinedev#7491)

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 11 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/react-router/src/safe-decode-uri-component.ts">

<violation number="1" location="packages/react-router/src/safe-decode-uri-component.ts:1">
P2: The `safeDecodeURIComponent` utility is duplicated in three separate packages (core inline, react-router, remix-router) with identical logic. Since both router packages already depend on `@refinedev/core` as a peer dependency, this utility could be exported from core once and imported by the router packages, eliminating the duplication and reducing the risk of behavioral drift.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

@@ -0,0 +1,7 @@
export const safeDecodeURIComponent = (value: string) => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The safeDecodeURIComponent utility is duplicated in three separate packages (core inline, react-router, remix-router) with identical logic. Since both router packages already depend on @refinedev/core as a peer dependency, this utility could be exported from core once and imported by the router packages, eliminating the duplication and reducing the risk of behavioral drift.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/react-router/src/safe-decode-uri-component.ts, line 1:

<comment>The `safeDecodeURIComponent` utility is duplicated in three separate packages (core inline, react-router, remix-router) with identical logic. Since both router packages already depend on `@refinedev/core` as a peer dependency, this utility could be exported from core once and imported by the router packages, eliminating the duplication and reducing the risk of behavioral drift.</comment>

<file context>
@@ -0,0 +1,7 @@
+export const safeDecodeURIComponent = (value: string) => {
+  try {
+    return decodeURIComponent(value);
</file context>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant