Skip to content

docs: add documentation pages for the Agent pack#12057

Merged
anakin87 merged 9 commits into
mainfrom
agent-pack-docs
Jul 20, 2026
Merged

docs: add documentation pages for the Agent pack#12057
anakin87 merged 9 commits into
mainfrom
agent-pack-docs

Conversation

@anakin87

@anakin87 anakin87 commented Jul 17, 2026

Copy link
Copy Markdown
Member

Related Issues

Proposed Changes:

  • document the Agent pack and its agents
    • most of the content for specific Agents comes from the Readmes

How did you test it?

Vercel preview

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
haystack-docs Ready Ready Preview, Comment Jul 20, 2026 7:56am

Request Review

@anakin87
anakin87 marked this pull request as ready for review July 17, 2026 15:34
@anakin87
anakin87 requested a review from a team as a code owner July 17, 2026 15:34
@anakin87
anakin87 requested review from julian-risch and sjrl and removed request for a team July 17, 2026 15:34
@anakin87

Copy link
Copy Markdown
Member Author

@julian-risch sorry I was already working on this but did not self-assign the issue to me. 😢

@sjrl feel free to review but also edit, specifically the Advanced RAG part.

@julian-risch

julian-risch commented Jul 17, 2026

Copy link
Copy Markdown
Member

@anakin87 No worries. Glad you have something already. Just wondering if one long page is really better than one page per pre-configured agent plus one overview page? What when we add more and more of these agents?

Comment thread docs-website/docs/pipeline-components/agents-1/agent-pack.mdx Outdated
Comment thread docs-website/docs/pipeline-components/agents-1/agent-pack.mdx Outdated
Comment thread docs-website/docs/pipeline-components/agents-1/agent-pack/advanced-rag-agent.mdx Outdated
- `hooks` merges additional [hooks](../hooks.mdx) per hook point with the built-in ones. For `after_run`, the built-in backup-answer hook runs first, so custom hooks see the final answer.
- `raise_on_tool_invocation_failure` makes a failing tool call raise when `True`, instead of returning the error to the LLM as a message it can recover from. Defaults to `False`.

## How it works

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would put this section near the top before Installation. As a reader I probably want to see and understand the motivation for this pre-made agent to be convinced to use it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very convinced since the "How it works" section is dense and full of details. In addition, we have now added the section "When to use this Agent," which can serve as an introduction.

WDYT?

| `fetch_documents_by_filter` | `FetchDocumentsByFilterTool` | Fetches documents directly through a metadata filter, when relevance scoring is unnecessary (for example a known title or file). |
| `search_documents` | [`ComponentTool`](../../../tools/componenttool.mdx) over your retriever, or [`PipelineTool`](../../../tools/pipelinetool.mdx) over your retrieval pipeline | Retrieves documents for a query by relevance, optionally narrowed by a metadata filter. Bounded by the `top_k` of your retrieval components. An empty result nudges the agent to relax the filter. |

`fetch_documents_by_filter` returns its results in reading order, grouping documents by parent file and sorting by split or page. It shows at most `max_docs` per call and reports the total match count, so larger match sets can be paged through with the tool's `offset` input. On stores that can count documents by filter, an over-broad filter is refused before any documents are fetched, and the refusal is returned to the LLM as an error it recovers from by narrowing the filter.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think in this PR but I wonder if we should make dedicated tools docs pages for this set of tools. Might be a more natural place to expand on the tools in detail like we have for other pre-built tools in core integrations and in core

@sjrl

sjrl commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@anakin87 looking good! One more general comment I would have is to add a section (or put it under How it Works) of when I should use this agent or why should I use it. For example for the advanced rag agent I would to convey the points:

Use the advanced rag agent when:

  • You have a large heterogeneous corpus (e.g. many topics, sources, doc types mixed together) that have well structured metadata. This allows the Agent to very precise in its retrieval through using filters vs just using relevance ranking alone.
  • You sometimes need exact or complete subsets by metadata — "all pages of this file," "everything from source X." fetch_documents_by_filter pulls those directly, without forcing it through relevance search.

This is less useful when:

  • No / non-discriminating metadata — nothing to filter on.
  • Small, homogeneous corpus where top-k already returns the right docs

anakin87 and others added 2 commits July 20, 2026 09:33
@anakin87

Copy link
Copy Markdown
Member Author

Just wondering if one long page is really better than one page per pre-configured agent plus one overview page? What when we add more and more of these agents?

@julian-risch could you better explain?

@julian-risch

Copy link
Copy Markdown
Member

Just wondering if one long page is really better than one page per pre-configured agent plus one overview page? What when we add more and more of these agents?

@julian-risch could you better explain?

Nevermind, I thought I only saw the agent-pack page but not the individual pages, one for each agent. It's good as is.

@julian-risch
julian-risch removed their request for review July 20, 2026 07:50
@anakin87

Copy link
Copy Markdown
Member Author

One more general comment I would have is to add a section (or put it under How it Works) of when I should use this agent or why should I use it.

Now added for the two Agents.

@sjrl sjrl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@anakin87
anakin87 merged commit 38144f9 into main Jul 20, 2026
19 checks passed
@anakin87
anakin87 deleted the agent-pack-docs branch July 20, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants