fix: preserve lazy toolsets added before warm-up#12012
Open
Success6666 wants to merge 1 commit into
Open
Conversation
|
Someone is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
Success6666
force-pushed
the
fix/toolset-add-lazy
branch
from
July 15, 2026 01:30
f232c08 to
91b86c8
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Toolset.add()only warmed the object being added when the parent had already been warmed. A lazy childToolsetwas therefore flattened while still empty when added to a cold parent, and its tools could not be recovered later.Toolsetinstances before flattening them.Toolinstances.How did you test it?
hatch run test:unit test/tools/test_toolset.py -q(33 passed)hatch run test:types(Success: no issues found in 371 source files)hatch run pre-commit run --files haystack/tools/toolset.py test/tools/test_toolset.py releasenotes/notes/fix-toolset-add-lazy-c73a533f031c72d2.yamlNotes for the reviewer
The change intentionally warms only child
Toolsetinstances before flattening. Adding a plainToolto a cold parent remains deferred until the parent is warmed.This PR was fully generated with an AI assistant. The changes were reviewed against the affected code path and the relevant tests were run locally.
Checklist
fix:.