Skip to content

CI: keep PR review plan comment checkout in sync#339

Merged
QG-phy merged 1 commit into
deepmodeling:mainfrom
QG-phy:fix-pr-review-plan-comment-checkout
Jun 3, 2026
Merged

CI: keep PR review plan comment checkout in sync#339
QG-phy merged 1 commit into
deepmodeling:mainfrom
QG-phy:fix-pr-review-plan-comment-checkout

Conversation

@QG-phy
Copy link
Copy Markdown
Collaborator

@QG-phy QG-phy commented Jun 3, 2026

Summary

  • fix the PR review plan comment workflow for older open PRs whose base SHA predates the latest helper script
  • checkout the trusted base branch ref instead of the old pull request base SHA
  • keep fork safety: the workflow still does not checkout or execute fork code

Root Cause

For PR #330, the workflow file from current main invoked pr_review_plan.py --format github-comment, but the job checked out github.event.pull_request.base.sha, which pointed at an older main commit that did not support that flag. The script exited with code 2 before updating the comment.

Validation

  • ruby -e 'require yaml; YAML.load_file(.github/workflows/pr_review_plan_comment.yml)'
  • python3 scripts/ci/check_repository_hygiene.py
  • Simulated PR Add DFTB-SCC support to DeePTB #330 changed-file input through python3 scripts/ci/pr_review_plan.py --stdin --format github-comment

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 3, 2026

Warning

Review limit reached

@QG-phy, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 2 minutes and 57 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7bec10c6-cdc6-4635-8169-0517d4ce71a6

📥 Commits

Reviewing files that changed from the base of the PR and between 4cfcd93 and f597bc4.

📒 Files selected for processing (1)
  • .github/workflows/pr_review_plan_comment.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

This advisory review plan was generated from changed file names using trusted base-branch code.
此审查计划由受信任的 base 分支代码根据变更文件名生成,仅作为维护者辅助。

DeePTB PR Review Plan / DeePTB PR 审查计划

Risk / 风险等级: Medium (中) · Changed files / 变更文件: 1

Why / 风险来源

  • GitHub Actions and CI changed. / GitHub Actions 与 CI 有变更。

Recommended Review / 建议审查重点

  • Run the Maintainer Review Prompt. / 运行维护者审查 prompt。
  • Run the Test Gap Review Prompt. / 运行测试缺口审查 prompt。
  • Confirm the changed behavior matches the PR scope. / 确认变更行为和 PR 范围一致。
Detailed risk areas
  • GitHub Actions and CI (Medium): .github/workflows/pr_review_plan_comment.yml
Human review focus
  • GitHub Actions and CI: trigger scope, required checks, dependency installation, and runtime noise
Local commands and hold conditions

Suggested local commands:

  • python scripts/ci/check_repository_hygiene.py
  • uv run pytest ./dptb/tests -m smoke
  • uv run pytest ./dptb/tests -m "not slow"

Hold conditions:

  • CI failed and the failure is not explained.
  • The PR scope is unclear or mixes unrelated changes.
  • AI review found a plausible correctness issue that was not fixed or explicitly waived.

Advisory only. / 仅作为审查辅助。

@QG-phy QG-phy merged commit 1d9c9fc into deepmodeling:main Jun 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant