CI runs every database test, and a missing database fails instead of skipping - #260
Merged
Conversation
…skipping Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Sep 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #248.
cargo test --workspacein the backend job has no database, so every store integration test returned early and the job was green; the migrations job, which has a database, ran onlygraph_changes.One guard, two modes.
utopia_store::test_db::url()replaces the four-line env check in all 25 test files (34 guards). WithoutUTOPIA_DATABASE_URLit skips, as before, so a localcargo teststill needs no database. WithUTOPIA_TEST_REQUIRE_DB=1as well, a missing database panics — the run must not skip.CI: the migrations job now runs
cargo test -p utopia-storewith both variables and writes a one-line summary (passed / failed, and that skips fail the job) to the step summary. The backend job is unchanged. Verified locally: with the variable set and no URL the test fails at the guard; with the URL the whole suite passes.CONTRIBUTING shows the new guard and asks new tests to use it. Two tests in flight (#257, #258) still carry the old four lines; they keep skipping quietly until they are switched over after merge.
🤖 Generated with Claude Code