Every source kind the UI offers can be created - #253
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #247.
The store's hand-written
KINDSallowlist stopped at seven kinds while the sync dispatcher and the UI knew twelve, sos3,azure_blob,gcs,webdavandnotionfailed at creation withkind must be one of…. The table has no CHECK; the allowlist was the only gate.One enum, three consumers.
SourceKindinutopia-core(strum for the strings and the iteration) now yields the creation allowlist, andsync_sourcematches it exhaustively — a new kind without a sync decision is a compile error. The frontend's list lives once, inweb/src/sourceKinds.ts, and feeds the create dialog, theSourceViewtype and the icon map (typedRecord<SourceKind, …>, so a kind without an icon failstsc). A store test reads that file and compares it to the enum, order included, so the three lists cannot drift apart again.Verified in the isolated environment: all five kinds create through the API (secrets stripped from the response as of #249), an unknown kind lists the twelve, and the dialog creates a WebDAV source end to end.
0013 carries a revision note.
🤖 Generated with Claude Code