Same-name entities of sibling classes go to the Duplicates queue - #232
Merged
Conversation
Closes #226 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #226.
classify_type_driftonly knew a hard-coded trio (organization / project / product). With a real pack the same company is extracted as Organization, Corporation and OnlineBusiness, all under Organization, and none of those pairs reached Review > Duplicates although the entity panel pointed there. Resolution now also treats two classes as confusable when one is an ancestor of the other or they share a non-root ancestor (types_are_kin), so same-name mentions across sibling classes are created separately and queued for the adjudicator / a person, as the panel promises.🤖 Generated with Claude Code