A tombstone push no longer needs content, and a bad payload is not a sync failure - #229
Merged
Merged
Conversation
…sync failure Closes #225 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
WaylandYang
force-pushed
the
fix/tombstone-push-without-content
branch
from
September 2, 2026 21:43
fe0fd38 to
b8326ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #225.
contentin the push body now defaults to empty, so{"external_id": ..., "deleted": true}marks the document missing as the Ingest interfaces guide says. Push failures are split into rejected payloads (recorded in the run history, not marked as a source sync failure, no alert) and real ingest failures (unchanged behaviour).🤖 Generated with Claude Code