ci: DH-19408: PNAP Integration#417
Merged
stanbrub merged 54 commits intodeephaven:mainfrom Feb 25, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 20 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cpwright
reviewed
Feb 9, 2026
.github/scripts/adhoc.sh
Outdated
Comment on lines
+102
to
+104
| IP_ADDRESS=$(jq -r '.publicIpAddresses[0]' <<< "${RESPONSE}") | ||
| DEVICE_ID=$(jq -r '.id' <<< "${RESPONSE}") | ||
| echo "Got Address ${IP_ADDRESS} and Device Id ${DEVICE_ID}" |
There was a problem hiding this comment.
A test -z does seem like a reasonable safety check here.
cpwright
approved these changes
Feb 10, 2026
cpwright
reviewed
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrote an integration with Phoenix NAP (our new bare metal provider).
always()) routines was ~27 incidents last year, the probability of the purge-expired function having an impact is 0.28%. (Gotta love Copilot)