feat(keydir): store offsets and revalidate CRC on every get (#4)

crates/datawal-cli/src/commands.rs

@@ -126,7 +126,7 @@ fn cmd_get(args: GetArgs, json: bool) -> Result<ExitCode> {
     let mode: BytesMode = args.bytes.into();
     let truncate = truncate_for(args.no_truncate);
 
-    let store = DataWal::open(&args.store)
+    let mut store = DataWal::open(&args.store)
         .with_context(|| format!("open store {}", args.store.display()))?;
     match store.get(&key)? {
         Some(value) => {

crates/datawal-core/benches/compaction.rs

@@ -83,7 +83,7 @@ fn bench_compact_to_delete_heavy(c: &mut Criterion) {
     let mut group = c.benchmark_group("datawal_compact_to_delete_heavy");
 
     for &(label, ratio) in LIVE_RATIOS {
-        let (_src, kv) = populated_with_deletes(ratio);
+        let (_src, mut kv) = populated_with_deletes(ratio);
 
         group.bench_function(BenchmarkId::from_parameter(label), |b| {
             b.iter_with_setup(bench_tempdir, |out_dir| {
@@ -101,7 +101,7 @@ fn bench_compact_to_overwrite_heavy(c: &mut Criterion) {
     let mut group = c.benchmark_group("datawal_compact_to_overwrite_heavy");
 
     for &(label, ratio) in LIVE_RATIOS {
-        let (_src, kv) = populated_with_overwrites(ratio);
+        let (_src, mut kv) = populated_with_overwrites(ratio);
 
         group.bench_function(BenchmarkId::from_parameter(label), |b| {
             b.iter_with_setup(bench_tempdir, |out_dir| {
@@ -118,7 +118,7 @@ fn bench_export_jsonl(c: &mut Criterion) {
     let mut group = c.benchmark_group("datawal_export_jsonl");
 
     for &(label, ratio) in LIVE_RATIOS {
-        let (_src, kv) = populated_with_deletes(ratio);
+        let (_src, mut kv) = populated_with_deletes(ratio);
 
         group.bench_function(BenchmarkId::from_parameter(label), |b| {
             b.iter_with_setup(

crates/datawal-core/benches/datawal_kv.rs

@@ -72,7 +72,7 @@ fn bench_get(c: &mut Criterion) {
 
     for &n in KEYDIR_SIZES {
         group.bench_with_input(BenchmarkId::from_parameter(n), &n, |b, &n| {
-            let (_dir, kv) = populated_kv(n);
+            let (_dir, mut kv) = populated_kv(n);
             // Round-robin over the populated key range.
             let mut i = 0usize;
             b.iter(|| {

crates/datawal-core/examples/datawal_kv_demo.rs

@@ -57,7 +57,7 @@ fn main() -> Result<()> {
     );
 
     // Reopen the compacted directory and verify state.
-    let kv2 = DataWal::open(&compact_dir)?;
+    let mut kv2 = DataWal::open(&compact_dir)?;
     println!("after compact reopen: len={}", kv2.len());
     println!("  a = {:?}", kv2.get(b"a")?);
     println!("  b contains_key = {}", kv2.contains_key(b"b"));

crates/datawal-core/examples/soak.rs

@@ -452,7 +452,7 @@ fn run(cli: Cli) -> Result<()> {
     drop(log);
 
     // Final-state consistency: reopen and compare keydir to `expected`.
-    let reopen = DataWal::open(&cli.work_dir).context("final reopen")?;
+    let mut reopen = DataWal::open(&cli.work_dir).context("final reopen")?;
     let observed_keys: std::collections::HashSet<Vec<u8>> = reopen.keys().into_iter().collect();
     let expected_keys: std::collections::HashSet<Vec<u8>> = expected.keys().cloned().collect();