[module-sdk] fix: preserve crd vendor extensions#122
Merged
Conversation
Signed-off-by: Ruslan Gorbunov <ruslan.gorbunov@flant.com>
fuldaxxx
changed the title
4 tasks
Signed-off-by: Ruslan Gorbunov <ruslan.gorbunov@flant.com>
Signed-off-by: Ruslan Gorbunov <ruslan.gorbunov@flant.com>
fuldaxxx
marked this pull request as ready for review
July 20, 2026 07:58
ldmonster
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Apply CRDs as
unstructured(verbatim) instead of decoding them into the typedapiextensionsv1.CustomResourceDefinitionbefore writing. The typed struct isnow used only to read metadata (names/versions/GVK,
storedVersions); the diffruns on the lossless unstructured
.spec, the in-clusterspec.conversionispreserved, and a regression test covers a vendor extension surviving the install
path.
Why do we need it, and what problem does it solve?
The installer decoded CRDs into a typed struct that has no catch-all for vendor
OpenAPI extensions, so any non-standard
x-*field(
x-kubernetes-sensitive-data,x-ui-*,x-kubernetes-patch-strategy, …) wassilently dropped before apply. And since the read-back path was also typed, the
diff never saw the difference, so the update never fired and re-runs didn't
self-heal. The installer should transport the CRD as-is and leave schema
validation to the API server.