chore(lint): étendre ESLint à tout src/ et tests/ (E10-3, #164) - #171
Merged
Conversation
Cause racine des fuites de contenu : le lint ne couvrait que src/engine. Désormais `npm run lint` = `eslint src tests` — la couche UI/jeu suit les mêmes standards que le moteur. - eslint.config.js : src/ui rejoint le périmètre ; eqeqeq garde l'idiome délibéré `x == null` (null: 'ignore'), === strict partout ailleurs ; les tests reçoivent les globals browser (callbacks page.evaluate du harnais). - Corrections réelles révélées : import LEVELS mort (world.js), let→const, == → === hors null-checks. - Refactors pour passer sous 50 lignes/fonction (standard du moteur), à comportement identique (tests + 9 écrans visuels à 0,00 %) : createTracker → helpers purs read/write/applyState/collectDue ; renderRegionMap → helpers roomLink/regionBlock ; Game.evaluate → extraction evaluateSandbox. 655 tests OK, lint vert sur tout src/+tests/, visuels conformes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ferme #164. Cause racine des oublis de traduction/CSS en dur : le lint ne couvrait que
src/engine. Désormaisnpm run lint=eslint src tests.Config
src/uirejoint le périmètre (retiré designores).eqeqeq:===strict partout, sauf l'idiome délibéréx == null(null: 'ignore').browserajoutés (les callbackspage.evaluatedu harnais visuel référencentdocument/window).Corrections réelles révélées
LEVELSmort dansworld.js.let→const(2 tests),==→===hors null-checks.Refactors sous 50 lignes/fonction (comportement identique)
Garantis par les tests + les 9 écrans visuels (0,00 % de diff) :
createTracker→ helpers pursread/write/applyState/collectDue/applyReviewed.renderRegionMap→ helpersroomLink/regionBlock.Game.evaluate→ extractionevaluateSandbox.655 tests OK · lint vert sur tout
src/+tests/· visuels conformes.