Skip to content

refactor: clean-room rewrites the post-merge CLA audit found (wave 3) - #3578

Merged
velixio merged 7 commits into
mainfrom
cla/rewrite-wave-3
Oct 27, 2026
Merged

velixio merged 7 commits into
mainfrom
cla/rewrite-wave-3

Conversation

@velixio

@velixio velixio commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #3563 and #3564. A post-merge audit of main found unsigned contributor work that the two waves left in place; this PR rewrites it with the same clean-room process.

Batch Source PRs What
N3 #2208 EPUB page-number, namespace and package handling, plus its tests. Merging the two waves kept wave 1's copy of longform_import.py and its test, which still held #2208's original lines. Batch G's clean tests stay unchanged as acceptance tests.
V3 #157, #1874, #2244, #2495 617 catalog values the waves did not cover: the contributors' own translations of their new keys in the other locales, 198 Simplified Chinese values in the shared catalog, and 8 English values that still matched the original.

Gatekeeping

  • Implementers worked in an isolated export from the removal commit; their transcripts show no access outside the sandbox.
  • N3: 0% spec leak. The scoped matches that remain are the vocabulary lists the spec dictates and the fixed EPUB packaging (container.xml, manifest items). Blame finds no fix: harden EPUB imports and Electron workspace navigation #2208 lines left in the implementation.
  • V3: no retranslated value over 14 characters matches the removed one. The matches that remain are one- or two-word labels, under the same rule used in every earlier catalog batch.
  • The six commits that reached main after refactor: clean-room rewrites of contributions without a CLA (wave 2 of 2) #3564 are by the owner, with no co-authors.

Testing

  • EPUB suites: 37 passed, including batch G's 23 tests.
  • pytest tests/, backend/tests, locale:check, tsc, vitest (renderer and shared) and node tests are green. Two exceptions also fail on main: source-checkout (ZIP) and test_storage_report. A few profile and consent tests crash only under -n auto and pass serially.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@velixio
velixio merged commit 0f084c5 into main Oct 27, 2026
25 of 28 checks passed
@velixio
velixio deleted the cla/rewrite-wave-3 branch October 27, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant