Repository navigation
refactor: clean-room rewrites the post-merge CLA audit found (wave 3) - #3578
Merged
Merged
Conversation
…eft by the wave merge, pending clean-room reimplementation
…namespace and package handling left by the wave merge
…ying contributor wording
Contributor
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #3563 and #3564. A post-merge audit of
mainfound unsigned contributor work that the two waves left in place; this PR rewrites it with the same clean-room process.longform_import.pyand its test, which still held #2208's original lines. Batch G's clean tests stay unchanged as acceptance tests.Gatekeeping
container.xml, manifest items). Blame finds no fix: harden EPUB imports and Electron workspace navigation #2208 lines left in the implementation.mainafter refactor: clean-room rewrites of contributions without a CLA (wave 2 of 2) #3564 are by the owner, with no co-authors.Testing
pytest tests/,backend/tests,locale:check,tsc, vitest (renderer and shared) and node tests are green. Two exceptions also fail onmain:source-checkout(ZIP) andtest_storage_report. A few profile and consent tests crash only under-n autoand pass serially.