Skip to content

test(lifecycle): handle both valid SIGKILL diagnostics - #2171

Merged
debpalash merged 1 commit into
mainfrom
fix/signal-diagnostic-ci
Sep 17, 2026
Merged

debpalash merged 1 commit into
mainfrom
fix/signal-diagnostic-ci

Conversation

@debpalash

@debpalash debpalash commented Sep 17, 2026

Copy link
Copy Markdown
Owner

Summary

On a slow runner, the SIGKILL lifecycle scenario can fail during readiness instead of reaching the supervisor. Rust's startup diagnostic says signal: 9 (SIGKILL); the supervisor says signal 9. Both correctly name the death, but the test accepted only the latter.

Accept both existing diagnostics and retain the independent crash-marker assertions requiring signal 9 and no exit code. No runtime or release behavior changes.

Changes

Accept both existing diagnostic formats; keep the structured crash-marker assertions. Follow-up to #2170.

Type

  • Tests

Testing

  • Main run 35211719420 reproduced the failing startup diagnostic on macOS.
  • The old assertion rejects that exact message; the revised assertion accepts it while retaining structured signal validation.
  • Targeted native Linux lifecycle test passes locally (1 passed); platform checks run in CI.

Checklist

  • Tested locally; relevant results above.
  • Relevant documentation and changelog updated.
  • No personal paths, logs, or environment details committed.
  • No version changes.
  • Full CI, including platform smoke checks, green before merge.

Release cadence

Continuous-to-main after review and CI. No release, tag, or version bump requested by this PR.

@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Retrigger

The PR appears safe to merge with no concrete behavioral, security, or repository-rule violations identified.

Summary

Broadens the SIGKILL lifecycle regression test to accept diagnostics from either the readiness or supervisor path and documents the fix in the changelog.

Reviews (1) · Last reviewed commit: "test: accept startup and supervisor SIGK..."

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 890e6ac1-74bc-4304-a727-ccc2013f7861

📥 Commits

Reviewing files that changed from the base of the PR and between a8581f8 and b1f900c.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • frontend/src-tauri/tests/backend_lifecycle.rs

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Lifecycle regression check

Layer / File(s) Summary
SIGKILL diagnostic compatibility
frontend/src-tauri/tests/backend_lifecycle.rs, CHANGELOG.md
The SIGKILL lifecycle test accepts signal 9 and signal: 9 (SIGKILL). The unreleased changelog records the fix.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: kevin9327

Merge Risk: ⚪ Minimal · up to b1f90

No production behavior changes are introduced, and the updated lifecycle test accepts both supported diagnostics.

🚥 Pre-merge checks | ✅ 9
✅ Passed checks (9 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Cross-Platform Default Parity ✅ Passed PASS: The authoritative diff changes only CHANGELOG.md and the Unix-gated backend lifecycle test. It broadens a test assertion from signal 9 to also accept signal: 9 (SIGKILL) and does not change …
I18n Completeness (21 Locales) ✅ Passed The PR changes only CHANGELOG.md and the Rust test frontend/src-tauri/tests/backend_lifecycle.rs. The added literals are test assertions for SIGKILL diagnostics, not application user-facing strings, a…
Local-First Guarantee ✅ Passed PASS — The PR changes only CHANGELOG.md and one existing local Rust lifecycle test. The code change broadens a diagnostic assertion and retains local marker checks; it adds no cloud call, account, A…
Backward Compatibility ✅ Passed PASS: The pull request changes only CHANGELOG.md and the SIGKILL lifecycle test. The Rust change broadens a test diagnostic assertion and keeps signal and exit-code checks. It does not change omnivoic…
Title check ✅ Passed The title uses conventional-commit style with the test(lifecycle): scope and clearly describes the test change. The issue reference #2170 appears in the pull request body.
Description check ✅ Passed The description includes all required sections, explains the change, identifies testing performed, and documents that no runtime or version changes were made. The unchecked full-CI item records pendin…

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@debpalash debpalash changed the title test: handle both valid SIGKILL lifecycle diagnostics test(lifecycle): handle both valid SIGKILL diagnostics Sep 17, 2026
@debpalash
debpalash merged commit 418b1b2 into main Sep 17, 2026
18 checks passed
@debpalash
debpalash deleted the fix/signal-diagnostic-ci branch September 17, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant