test(lifecycle): handle both valid SIGKILL diagnostics - #2171
Conversation
|
The PR appears safe to merge with no concrete behavioral, security, or repository-rule violations identified. SummaryBroadens the SIGKILL lifecycle regression test to accept diagnostics from either the readiness or supervisor path and documents the fix in the changelog. Reviews (1) · Last reviewed commit: "test: accept startup and supervisor SIGK..." |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughChangesLifecycle regression check
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to No production behavior changes are introduced, and the updated lifecycle test accepts both supported diagnostics. 🚥 Pre-merge checks | ✅ 9✅ Passed checks (9 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
On a slow runner, the SIGKILL lifecycle scenario can fail during readiness instead of reaching the supervisor. Rust's startup diagnostic says
signal: 9 (SIGKILL); the supervisor sayssignal 9. Both correctly name the death, but the test accepted only the latter.Accept both existing diagnostics and retain the independent crash-marker assertions requiring signal 9 and no exit code. No runtime or release behavior changes.
Changes
Accept both existing diagnostic formats; keep the structured crash-marker assertions. Follow-up to #2170.
Type
Testing
Checklist
Release cadence
Continuous-to-main after review and CI. No release, tag, or version bump requested by this PR.