Skip to content

Fixes #135 bug causing gaps to occur when dragging #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chtrinh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes #135 bug causing gaps to occur when dragging #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,15 @@ class SortableListView extends React.Component {
}

handleContentSizeChange = (width, height) => {
this.scrollContainerHeight = height
}
this.scrollContainerHeight = height;

// NOTE: Need to recalcuate the scrollView height when items are drag-and-hold beyond the
// length of the list and back into it. Without this checkTargetElement uses the old
// cache verison the height of the scrollView creating a gap.
if (this.scrollValue > 0) {
this.scrollTo({ y: height, animated: !this.props.disableAnimatedScrolling });
}
};

scrollAnimation = () => {
if (this.state.active) {
Expand Down