feat: extract item investment stats to generic data#368
Draft
LVL1024 wants to merge 2 commits into
Draft
Conversation
- Extracts `m_MapModCostBonuses` from selectable heroes - Validates that investment scaling is identical across all heroes - Maps engine slot types to standard categories (Weapon, Vitality, Spirit) - Appends `ItemInvestments` to generic-data.json and adds it to structure validation
LVL1024
force-pushed
the
feature/add-investments
branch
from
f3e28ae to
fa8eee3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valve currently stores the item investment thresholds (the stat bonuses you get at 800, 1600 souls, etc.) inside every individual hero's data. Since it's a global mechanic, this PR pulls that data out and tosses it into
generic-data.jsonso the wiki modules can easily grab it from one place.What it does:
m_MapModCostBonusesand maps the slots toWeapon,Vitality, andSpirit.generic-data.jsonunderItemInvestments.Parsed data in deadlock-data PR - Reopen deadbot PR or run deploy workflow for this branch here to reparse the data