Skip to content

fix: parse embedded token amounts and parenthesized UTC times - #65

Closed
deKibi wants to merge 1 commit into
mainfrom
fix/embedded-converter-parsing
Closed

fix: parse embedded token amounts and parenthesized UTC times#65
deKibi wants to merge 1 commit into
mainfrom
fix/embedded-converter-parsing

Conversation

@deKibi

@deKibi deKibi commented Jul 30, 2026

Copy link
Copy Markdown
Owner

Fix parsing for converter expressions embedded inside long text messages.

Changes

  • Support optional token / tokens suffixes after crypto tickers, e.g. 250 AEON tokens.
  • Support parenthesized named timezones, e.g. 10:00 (UTC).
  • Add regression coverage for the Binance Alpha announcement text containing both crypto and time converter matches.

@deKibi deKibi self-assigned this Jul 30, 2026
@deKibi

deKibi commented Jul 30, 2026

Copy link
Copy Markdown
Owner Author

@codex Please verify that this PR correctly parses both 250 AEON tokens and 10:00 (UTC) from the provided long Binance Alpha message, and that existing crypto/time converter formats, handler priority, and deduplication behavior remain unchanged.

Binance Alpha example message:

Binance Alpha is the first platform to feature AEON (AEON), with Alpha debut and trading starting on July 27, 2026, at 10:00 (UTC). 

Users with at least 245 Binance Alpha Points can claim an airdrop of 250 AEON tokens on a first-come, first-served basis. If the reward pool is not fully distributed, the score threshold will automatically decrease by 5 points every 5 minutes.

Please note that claiming the airdrop will consume 15 Binance Alpha Points. Users must confirm their claim on the Alpha Events page within 24 hours; otherwise, it will be deemed that users have given up claiming the airdrop.

The same behaviour expected in other similar examples
Check for regressions according this feature

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5d528d3663

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crypto_converter/crypto_amount_parser.py
@deKibi

deKibi commented Jul 30, 2026

Copy link
Copy Markdown
Owner Author

Closing this PR because it combines two separate scopes. The time parsing fix will be moved to a dedicated PR, while AEON support requires a separate decision around the existing market-cap rank guardrail.

@deKibi deKibi closed this Jul 30, 2026
@deKibi
deKibi deleted the fix/embedded-converter-parsing branch July 30, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant