Skip to content

Update to redis 8, fixes #51 #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bserem wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update to redis 8, fixes #51 #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ Use the `ddev redis-backend` command to swap between Redis backends:

| Command | Docker Image |
|--------------------------------------|-----------------------------------------------|
| `ddev redis-backend redis` | `redis:7` |
| `ddev redis-backend redis-alpine` | `redis:7-alpine` |
| `ddev redis-backend redis` | `redis:8` |
| `ddev redis-backend redis-alpine` | `redis:8-alpine` |
| `ddev redis-backend valkey` | `valkey/valkey:8` |
| `ddev redis-backend valkey-alpine` | `valkey/valkey:8-alpine` |
| `ddev redis-backend <image>` | `<image>` (specify your custom Redis image) |
Expand Down Expand Up @@ -96,7 +96,7 @@ Make sure to commit the `.ddev/.env.redis` file to version control.
To change the used Docker image:

```bash
ddev dotenv set .ddev/.env.redis --redis-docker-image=redis:7
ddev dotenv set .ddev/.env.redis --redis-docker-image=redis:8
ddev add-on get ddev/ddev-redis

# (optional) if you have an existing Redis volume, delete it to avoid problems with Redis:
Expand All @@ -112,7 +112,7 @@ All customization options (use with caution):

| Variable | Flag | Default |
| -------- | ---- | ------- |
| `REDIS_DOCKER_IMAGE` | `--redis-docker-image` | `redis:7` |
| `REDIS_DOCKER_IMAGE` | `--redis-docker-image` | `redis:8` |
| `REDIS_HOSTNAME` | `--redis-hostname` | `redis` |
| `REDIS_OPTIMIZED` | `--redis-optimized` | `false` (`true`/`false`) |

Expand Down
14 changes: 7 additions & 7 deletions commands/host/redis-backend
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ Note that not every Docker image can work right away, and you may need to overri
the "command:" in the docker-compose.redis_extra.yaml file

Available aliases:
redis redis:7
redis-alpine redis:7-alpine
redis redis:8
redis-alpine redis:8-alpine
valkey valkey/valkey:8
valkey-alpine valkey/valkey:8-alpine

Expand Down Expand Up @@ -70,19 +70,19 @@ function check_docker_image() {
}

function use_docker_image() {
[[ "$REDIS_DOCKER_IMAGE" != "redis:7" ]] && ddev dotenv set .ddev/.env.redis --redis-docker-image="$REDIS_DOCKER_IMAGE"
[[ "$REDIS_DOCKER_IMAGE" != "redis:8" ]] && ddev dotenv set .ddev/.env.redis --redis-docker-image="$REDIS_DOCKER_IMAGE"
REPO=$(ddev add-on list --installed -j 2>/dev/null | docker run -i --rm ddev/ddev-utilities jq -r '.raw[] | select(.Name=="redis") | .Repository // empty' 2>/dev/null)
ddev add-on get "${REPO:-ddev/ddev-redis}"
}

case "$REDIS_DOCKER_IMAGE" in
redis)
NAME="Redis 7"
REDIS_DOCKER_IMAGE="redis:7"
NAME="Redis 8"
REDIS_DOCKER_IMAGE="redis:8"
;;
redis-alpine)
NAME="Redis 7 Alpine"
REDIS_DOCKER_IMAGE="redis:7-alpine"
NAME="Redis 8 Alpine"
REDIS_DOCKER_IMAGE="redis:8-alpine"
;;
valkey)
NAME="Valkey 8"
Expand Down
4 changes: 2 additions & 2 deletions docker-compose.redis.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
services:
redis:
container_name: ddev-${DDEV_SITENAME}-redis
image: ${REDIS_DOCKER_IMAGE:-redis:7}
image: ${REDIS_DOCKER_IMAGE:-redis:8}
hostname: ${REDIS_HOSTNAME:-redis}
# These labels ensure this service is discoverable by ddev.
labels:
Expand All @@ -19,7 +19,7 @@ services:
command: /etc/redis/conf/redis.conf
x-ddev:
describe-url-port: |
Backend: ${REDIS_DOCKER_IMAGE:-redis:7}
Backend: ${REDIS_DOCKER_IMAGE:-redis:8}
describe-info: |
Pass: <none>

Expand Down
Loading