feat: add CORS headers, fixes #17

[ben-hamelin]

The Issue

#17

How This PR Solves The Issue

Adds http.cors configuration to the compose file

Manual Testing Instructions

Make a Javascript "fetch()" request from either a decoupled localhost environment, or from any other locally hosted webpage, could even be static HTML.

Automated Testing Overview

I am reviewing the tests now to see if there are any that require an update, or if it is appropriate to create a new one

Related Issue Link(s)

Release/Deployment Notes

[rfay]

Since you're a new contributor, the tests have to be allowed manually on this first PR to this repo. Ping me when you push new things and I'll allow again.

[rfay]

Are these environment variables? Or some other type of configuration? Dots in environment variables are unusual. And who consumes this information?

[ben-hamelin]

This is configuration used by ES, based on documentation here: https://www.elastic.co/guide/en/elasticsearch/reference/current/behavioral-analytics-cors.html#behavioral-analytics-cors-enable-cors-elasticsearch

[rfay]

Yes...

This is the simplest option. Enable CORS on Elasticsearch by adding the following to your elasticsearch.yml file:

They aren't environment variables, they have to be added to elasticsearch.yml. I'll bet they could also be added as command-line arguments to the elasticsearch daemon.

[ben-hamelin]

@rfay Following up on this. I can confirm the changes here work locally to resolve CORS errors. Would you prefer an updated approach that adds a "volumes" mapping to https://github.com/ddev/ddev-elasticsearch/blob/main/docker-compose.elasticsearch.yaml#L21 and a new elasticsearch7.yml file? I would review and apply the same settings for 8.

[rfay]

@AronNovak is the maintainer here, hopefully we can raise him :)

[stasadev]

Resolved conflicts and rebased on the latest HEAD.

[stasadev]

This config doesn't seem to work with Elasticsearch 8:

$ ddev logs -s elasticsearch
Exception in thread "main" org.elasticsearch.common.settings.SettingsException: Failed to load settings from [overrides.yml]
        at org.elasticsearch.common.settings.Settings$Builder.loadFromStream(Settings.java:1249)
        at org.elasticsearch.node.InternalSettingsPreparer.loadOverrides(InternalSettingsPreparer.java:143)
        at org.elasticsearch.node.InternalSettingsPreparer.prepareEnvironment(InternalSettingsPreparer.java:53)
        at org.elasticsearch.common.cli.EnvironmentAwareCommand.createEnv(EnvironmentAwareCommand.java:110)
        at org.elasticsearch.common.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:54)
        at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:85)
        at org.elasticsearch.cli.Command.main(Command.java:50)
        at org.elasticsearch.launcher.CliToolLauncher.main(CliToolLauncher.java:64)
Caused by: org.elasticsearch.xcontent.XContentParseException: [4:23] while scanning an alias
 in 'reader', line 4, column 25:
    http.cors.allow-origin: *
                            ^
unexpected character found