Repository navigation
Conversation
dd3ok
left a comment
There was a problem hiding this comment.
Multi-angle review completed against the requested simplification and repository contracts. Functionality, data integrity, lifecycle safety, performance, selection UX, packaging and complexity were inspected. The existing local suite passes (81 passed, 1 Windows-only fixture skipped), but targeted public-interface probes reproduce the two P2 regressions below. Keep this PR in draft until those are addressed; the P3 cache validation issue is a small robustness follow-up. No production behavior was changed during this review. CI is running separately.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
refresh.classify; use 50-card internal pages and 10 user-facing candidates. Preserve explicit selection before loading or executing instructions.The PR contains the accumulated Stash work since
e17206f, plus the focused review fixes inb1cec4fanddc0e347. Personal catalogs, installed skill contents, backups, and local configuration are not included.Initial review findings — all fixed
catalog-unavailable, not a misleading complete count. Refresh retries failed roots and reportsok/partial/failedfor its scope.id,displayName, orurlfields, then rebuild normally. The guard covers visible records and folded copies.The first follow-up CI run exposed an intermittent Windows
EPERMwhile concurrent refreshes replaced the same snapshot.dc0e347adds a Windows-only, EPERM-only publication retry (at most 5 attempts / 200 ms total delay). Persistent and unrelated errors still fail and preserve the previous cache; warm reads incur no retry or additional file I/O.No new command, dependency, router, cache file, validation framework, or background service was added by these fixes. Runtime changes are limited to four source files (net +31 lines); the bundle grew from 458,711 to 460,543 bytes (+0.40%).
Boundary coverage
EPERMis bounded; other errors fail immediately without replacing the old cache. A native Windows stress check passed 80 refreshes (20 rounds of 4 concurrent writers).Verification
npm run test:allpassed — 99 source tests and 11 distribution tests passed; 1 existing platform-specific filename fixture skipped.git diff --checkpassed.dc0e347passed: Ubuntu Node 20, Ubuntu Node 24, Windows Node 24, and macOS Node 24. All three initial review threads are resolved.Intentional breaking changes and limits
search,index, installation aliases, relevance fields, and legacy configuration fields.refresh. Semantic selection still depends on metadata and the host agent.The focused re-review found no remaining blocker among the three reported issues. Live installed skills, active states, and user catalogs were not modified. No automatic merge was performed.