You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove TODO comments from PINT specification schemas
pint/v3/EBL_PINT_v3.0.0.yaml
Removed 5 TODO comments from various schema fields
Cleaned up task markers from lastEnvelopeTransferChainEntrySignedContentChecksum, EnvelopeManifestSignedContent, previousEnvelopeTransferChainEntrySignedContentChecksum, issuanceManifestSignedContent, EnvelopeTransferChainEntrySignedContent, EnvelopeTransferFinishedResponse, and EnvelopeTransferFinishedResponseSignedContent
Preserved all example values and field descriptions
Align the inconsistent top-level and property-level examples for lastEnvelopeTransferChainEntrySignedContentChecksum in the EnvelopeTransferFinishedResponse schema to avoid confusion.
EnvelopeTransferFinishedResponse:
type: object
required:
- lastEnvelopeTransferChainEntrySignedContentChecksum
- responseCode
example:
lastEnvelopeTransferChainEntrySignedContentChecksum: d56a93a7e9f86a2d895df818e0440bdca6ffe03246e2fee14131f2e66c84c75a
responseCode: RECE
properties:
lastEnvelopeTransferChainEntrySignedContentChecksum:
type: string
minLength: 64
maxLength: 64
pattern: ^[0-9a-f]+$
description: |
This attribute should contain the checksum of the last [`EnvelopeTransferChainEntrySignedContent`](#/EnvelopeTransferChainEntrySignedContent) entry in the [`EblEnvelope.envelopeTransferChain[]`](#/EblEnvelope) list received. The checksum is computed using SHA-256 hash algorithm according to [RFC 6234](https://datatracker.ietf.org/doc/html/rfc6234).
- example: 20a0257b313ae08417e07f6555c4ec829a512c083f3ead16b41158018a22abe9+ example: d56a93a7e9f86a2d895df818e0440bdca6ffe03246e2fee14131f2e66c84c75a
[To ensure code accuracy, apply this suggestion manually]
Suggestion importance[1-10]: 5
__
Why: The suggestion correctly identifies an inconsistency between a top-level example and a property-level example, which can cause confusion. Fixing this improves the clarity and usability of the API specification.
Low
More
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
SD-2840: Remove
TODOfrom the specsPR Type
Documentation
Description
Remove TODO comments from specification files
Clean up outdated task markers in schema documentation
Maintain existing example values and descriptions
Diagram Walkthrough
File Walkthrough
EBL_ISS_v3.0.3.yaml
Remove TODO from issuanceManifestSignedContentebl/v3/issuance/EBL_ISS_v3.0.3.yaml
issuanceManifestSignedContentfieldEBL_PINT_v3.0.0.yaml
Remove TODO comments from PINT specification schemaspint/v3/EBL_PINT_v3.0.0.yaml
lastEnvelopeTransferChainEntrySignedContentChecksum,EnvelopeManifestSignedContent,previousEnvelopeTransferChainEntrySignedContentChecksum,issuanceManifestSignedContent,EnvelopeTransferChainEntrySignedContent,EnvelopeTransferFinishedResponse, andEnvelopeTransferFinishedResponseSignedContent