Skip to content

feat: link impact summary signals to explorer with smooth scroll - #108

Merged
dcotelo merged 2 commits into
mainfrom
emdash/shaggy-guests-smoke-4q2
Jun 29, 2026
Merged

dcotelo merged 2 commits into
mainfrom
emdash/shaggy-guests-smoke-4q2

Conversation

@dcotelo

@dcotelo dcotelo commented Mar 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • Clicking a risk signal in ImpactSummary now selects the corresponding resource in DiffExplorer and smoothly scrolls to it
  • Analysis context section is now collapsed by default to keep the focus on results
  • Added generateImpactStatement to risk-assessment.ts to produce plain-language summaries (e.g. "2 workloads will restart and 1 service port will change")
  • DiffExplorer accepts an optional selectedResource prop and syncs its internal selection via useEffect

Changes

  • analysis/page.tsx: added selectedResource state, explorerRef, and handleSelectResourceFromSummary handler; wires onSelectResource into ImpactSummaryComponent
  • ImpactSummary.tsx: threads onSelectResource callback down through Section and individual signal rows
  • DiffExplorer.tsx: new selectedResource prop with effect to sync external selection
  • risk-assessment.ts: new generateImpactStatement utility function

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Mar 3, 2026 •

Copy link
Copy Markdown

Deploying chartimpact with  Cloudflare Pages  Cloudflare Pages

Latest commit: ac002d6
Status:⚡️  Build in progress...

View logs

@dcotelo
dcotelo merged commit bd76f09 into main Jun 29, 2026
3 of 5 checks passed
@dcotelo
dcotelo deleted the emdash/shaggy-guests-smoke-4q2 branch June 29, 2026 18:59
@sonarqubecloud

Copy link
Copy Markdown

This was referenced Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant