fix: reject non-integer genSalt costs - #174
Open
official-burak wants to merge 1 commit into
Open
Conversation
Fractional costs were written into the salt with toString, so 10.5 became $2b$10.5$ and hashSync failed with Missing salt rounds. Fixes dcodeIO#173
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the clear repro. genSaltSync was writing the cost with toString, so a fractional value like 10.5 became
$2b$10.5$and hashSync then failed with Missing salt rounds.This rejects non-integer costs in genSaltSync, which also covers genSalt and hashSync when they generate a salt. I added a test for the 10.5 case so the salt path stays aligned with the two-digit cost hash already expects.
Fixes #173