Skip to content

fix: reject FlushToInsurance on trading LP pools (pool_mode == 1) #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0x-SquidSol wants to merge 1 commit into from
Closed

fix: reject FlushToInsurance on trading LP pools (pool_mode == 1) #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/processor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -840,6 +840,17 @@ fn process_flush_to_insurance(
return Err(StakeError::InvalidPercolatorProgram.into());
}

// FlushToInsurance moves vault funds to the wrapper insurance fund.
// This operation is only meaningful on insurance LP pools (mode 0).
// Trading LP pools (mode 1) use fee-based accounting; flushing would
// undercount pool value in AccrueFees (total_deposited - total_withdrawn
// formula doesn't subtract total_flushed) and leave the vault
// permanently below the expected accounting balance.
if pool.pool_mode != 0 {
msg!("FlushToInsurance: not valid for trading LP pools (mode 1)");
return Err(StakeError::InvalidPoolMode.into());
}

// Verify vault balance — can't flush more than what's available in vault
// Available = total_deposited - total_withdrawn - total_flushed
// Use checked_sub for defense-in-depth (saturating_sub hides accounting bugs)
Expand Down