Skip to content

fix(stake): #257 — add v17 devnet wrapper to the feature-gated devnet allowlist #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Morenikeoa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(stake): #257 — add v17 devnet wrapper to the feature-gated devnet allowlist #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/processor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,15 +444,28 @@ fn process_init_pool(
// pointing to it, and drain the vault via FlushToInsurance PDA-signer propagation.
// The devnet program ID has no legitimate use on mainnet; gate it with the
// "devnet" feature flag so it only compiles in when explicitly requested.
//
// #257: the legacy PERCOLATOR_DEVNET address above predates the v17 wrapper cutover.
// percolator-sdk's PROGRAM_IDS_V17.percolator ("69VUZ7a2BeXBTpRRManLamF5UWTaNR9B1hy5Se3cdXy9")
// is a SEPARATE, newer devnet-only deployment (SDK comment: "Mainnet addresses are
// pending the mainnet cutover (Phase 7 gate)" — there is no canonical v17 MAINNET
// address yet). Add it alongside, not in place of, the legacy devnet address, and
// keep it under the SAME "devnet" feature gate as PERCOLATOR_DEVNET for the same
// N-3 reason: it has no legitimate use on mainnet either.
{
const PERCOLATOR_MAINNET: Pubkey =
solana_program::pubkey!("ESa89R5Es3rJ5mnwGybVRG1GrNt9etP11Z5V2QWD4edv");
#[cfg(feature = "devnet")]
const PERCOLATOR_DEVNET: Pubkey =
solana_program::pubkey!("FxfD37s1AZTeWfFQps9Zpebi2dNQ9QSSDtfMKdbsfKrD");
#[cfg(feature = "devnet")]
const PERCOLATOR_V17_DEVNET: Pubkey =
solana_program::pubkey!("69VUZ7a2BeXBTpRRManLamF5UWTaNR9B1hy5Se3cdXy9");
let is_valid = *percolator_program.key == PERCOLATOR_MAINNET;
#[cfg(feature = "devnet")]
let is_valid = is_valid || *percolator_program.key == PERCOLATOR_DEVNET;
let is_valid = is_valid
|| *percolator_program.key == PERCOLATOR_DEVNET
|| *percolator_program.key == PERCOLATOR_V17_DEVNET;
if !is_valid {
msg!(
"Error: invalid percolator program {}",
Expand Down
23 changes: 23 additions & 0 deletions tests/unit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -933,6 +933,29 @@ fn test_percolator_program_allowlist_constants_match_nft() {
assert_ne!(devnet, Pubkey::default(), "devnet ID must not be zero");
}

#[test]
fn test_v17_devnet_wrapper_allowlist_constant_matches_sdk() {
// #257: percolator-sdk's PROGRAM_IDS_V17.percolator is a separate, newer
// devnet-only deployment from the legacy PERCOLATOR_DEVNET above (the SDK's
// own comment notes mainnet v17 addresses are "pending the mainnet cutover" —
// there is no canonical v17 MAINNET address yet, so only a devnet allowlist
// entry is correct here). This test encodes the expected value so drift is
// caught at test time, mirroring test_percolator_program_allowlist_constants_match_nft.
use solana_program::pubkey::Pubkey;

let mainnet: Pubkey = solana_program::pubkey!("ESa89R5Es3rJ5mnwGybVRG1GrNt9etP11Z5V2QWD4edv");
let legacy_devnet: Pubkey =
solana_program::pubkey!("FxfD37s1AZTeWfFQps9Zpebi2dNQ9QSSDtfMKdbsfKrD");
let v17_devnet: Pubkey = solana_program::pubkey!("69VUZ7a2BeXBTpRRManLamF5UWTaNR9B1hy5Se3cdXy9");

assert_ne!(v17_devnet, mainnet, "v17 devnet wrapper must differ from mainnet");
assert_ne!(
v17_devnet, legacy_devnet,
"v17 devnet wrapper must differ from the legacy (pre-v17) devnet wrapper"
);
assert_ne!(v17_devnet, Pubkey::default(), "v17 devnet ID must not be zero");
Comment on lines +937 to +956

@coderabbitai coderabbitai Bot Jun 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Find SDK dependency and any direct use of PROGRAM_IDS_V17 =="
fd 'Cargo.toml|Cargo.lock' . -x sh -c 'echo "--- $1"; rg -n "percolator-sdk|PROGRAM_IDS_V17" "$1" || true' sh {}

echo
echo "== Inspect current test/production references =="
rg -n -C2 'PROGRAM_IDS_V17|69VUZ7a2BeXBTpRRManLamF5UWTaNR9B1hy5Se3cdXy9|PERCOLATOR_V17_DEVNET' src tests

Repository: dcccrypto/percolator-stake

Length of output: 2387

Compare against the SDK-exported constant

These literals only prove the addresses differ; the test still passes if percolator-sdk changes PROGRAM_IDS_V17.percolator. Compare against the SDK constant or a shared source of truth instead of another hardcoded string.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/unit.rs` around lines 937 - 956, The v17 devnet wrapper test only
compares hardcoded Pubkeys against each other, so it can miss drift from the
SDK. Update test_v17_devnet_wrapper_allowlist_constant_matches_sdk to assert the
wrapper value matches the SDK-exported source of truth (for example the
percolator-sdk PROGRAM_IDS_V17.percolator constant) instead of another literal,
while keeping the existing sanity checks that it differs from mainnet/legacy and
is non-default.

}

#[test]
fn test_pool_stores_percolator_program() {
// Verify that a StakePool's percolator_program field is a full 32-byte pubkey.
Expand Down