fix(stake): #211 — validate LP recipient ownership on deposit (rebased #214)

[dcccrypto]

Rebased re-application of #214 (credit @Morenikeoa) — the original conflicted with #213/#216 in the test module. Adds validate_lp_recipient_account (SPL-owner + lp_mint + owner==depositor) before mint_to in process_deposit + process_deposit_junior, closing the LP-recipient-ownership gap (#211, MEDIUM griefing/stranding). build-sbf clean; 131 tests pass. Closes #211. Supersedes #214.

Summary by CodeRabbit

• Bug Fixes
  • Enhanced validation of LP token accounts in deposit operations to ensure proper authorization, correct ownership, and valid account configuration before processing transfers.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3597a790-6a82-45d6-83ea-aa2b93998510

📥 Commits

Reviewing files that changed from the base of the PR and between 7611e74 and 3e5102a.

📒 Files selected for processing (1)

• src/processor.rs

---

📝 Walkthrough

Walkthrough

A new internal helper validate_lp_recipient_account is added to src/processor.rs. It checks that user_lp_ata is SPL Token program-owned, has sufficient data length, holds the expected LP mint, and is owned by the depositor signer. Both process_deposit and process_deposit_junior now call this helper before LP tokens are minted.

Changes

LP Recipient Account Validation

Layer / File(s)	Summary
validate_lp_recipient_account helper and deposit call sites src/processor.rs	Defines the validate_lp_recipient_account function that enforces SPL Token ownership, minimum account length, LP mint match, and depositor owner match on user_lp_ata, returning InvalidAccount, InvalidMint, or Unauthorized on failure. Wires this check into process_deposit (line 673) and process_deposit_junior (line 2490) immediately before LP minting proceeds.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• dcccrypto/percolator-stake#30: Also adds reusable internal account-validation helpers in src/processor.rs and wires them into deposit flow call sites, the same structural pattern used here.
• dcccrypto/percolator-stake#208: Strengthens token account validation (SPL Token program ownership, discriminator checks) in process_deposit and process_deposit_junior, directly overlapping with the same deposit code locations modified here.
• dcccrypto/percolator-stake#172: Modifies deposit-cap enforcement logic in process_deposit and process_deposit_junior, touching the same deposit paths now guarded by the new LP recipient check.

Poem

🐇 Hop hop, no sneaky swap!
The LP receipt must match the signer's cap.
Mint, owner, program — all three must align,
Or Unauthorized halts the deposit design.
No mismatch receipts, no accounting gap —
The rabbit checks twice before closing the trap! 🌿

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/stake-214-v2

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}