fix: clamp computePnlPercent and computeFundingRateAnnualized instead of throwing - #328
fix: clamp computePnlPercent and computeFundingRateAnnualized instead of throwing#328Ayomisco wants to merge 1 commit into
Conversation
… of throwing Both functions threw an unhandled Error when their BigInt intermediate result exceeded Number.MAX_SAFE_INTEGER. In the UI these are called inside render and event handlers with no surrounding try/catch, so an extremely large position or extreme funding rate would crash the page. computePnlPercent now returns a clamped sentinel (MAX_SAFE_INTEGER / 100) for values beyond the safe range. computeFundingRateAnnualized returns +/-Infinity, which is the mathematically correct value and is handled safely by JS formatters.
|
Warning Review limit reached
More reviews will be available in 49 minutes and 13 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Fixes #327
Changes
src/math/trading.tscomputePnlPercent: replacethrowwith a clamped return (Number.MAX_SAFE_INTEGER / 100) whenscaledPctexceeds the safe integer rangecomputeFundingRateAnnualized: replacethrowwithreturn Infinity/return -Infinityfor the same boundary conditionWhy clamp instead of throw
Both functions are called from UI render paths with no try/catch. Returning a sentinel value (a very large percentage or Infinity) is correct behaviour for "effectively infinite" results and does not crash the page. The original throw was added to surface precision concerns but broke the caller contract for a pure display utility.