fix(onboarding): starter deposit is user-chosen - #2424
Conversation
Two paths deposited a hardcoded min(500, wallet balance) starter without the user ever picking a number: the silent AutoDepositProvider that fired after the faucet, and the one-click Start Trading CTA. The CTA now shows an editable amount field (prefilled with the suggested default once the wallet balance resolves, clamped to balance, user edits win), and the silent provider is removed — onboarding completes through the CTA where the amount is always visible and editable. Faucet modal copy updated to match. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Item 4 of the terminal UX fixes.
Problem: two onboarding paths deposited a system-chosen
min(500, wallet balance)without the user ever picking a number — the silentAutoDepositProviderthat fired after the faucet, and the one-click Start Trading CTA.Fix:
AutoDepositProviderremoved from the trade page (and the now-dead component deleted) — no deposit ever happens with an amount the user didn't see. TheuseAutoDeposithook + its tests remain (sharedAUTO_DEPOSIT_AMOUNTconstant, and DepositWithdrawCard's editable prefill already let the user choose).Verified:
tsc --noEmitclean; test suite green except the 4 pre-existing Privy/ConnectButton env failures.🤖 Generated with Claude Code