Skip to content

fix(onboarding): starter deposit is user-chosen - #2424

Merged
dcccrypto merged 1 commit into
playgroundfrom
fix/deposit-user-chosen
Jul 15, 2026
Merged

fix(onboarding): starter deposit is user-chosen#2424
dcccrypto merged 1 commit into
playgroundfrom
fix/deposit-user-chosen

Conversation

@dcccrypto

Copy link
Copy Markdown
Owner

Item 4 of the terminal UX fixes.

Problem: two onboarding paths deposited a system-chosen min(500, wallet balance) without the user ever picking a number — the silent AutoDepositProvider that fired after the faucet, and the one-click Start Trading CTA.

Fix:

  • The Start Trading CTA now has an editable deposit amount field directly above it — prefilled with the suggested default once the wallet balance resolves (a user edit always wins over the prefill), clamped to the wallet balance so the folded init+deposit tx can't bounce. One-click onboarding is preserved for users who accept the prefill.
  • AutoDepositProvider removed from the trade page (and the now-dead component deleted) — no deposit ever happens with an amount the user didn't see. The useAutoDeposit hook + its tests remain (shared AUTO_DEPOSIT_AMOUNT constant, and DepositWithdrawCard's editable prefill already let the user choose).
  • Faucet modal step-3 copy updated ("Pick your deposit in the order ticket").

Verified: tsc --noEmit clean; test suite green except the 4 pre-existing Privy/ConnectButton env failures.

🤖 Generated with Claude Code

Two paths deposited a hardcoded min(500, wallet balance) starter without
the user ever picking a number: the silent AutoDepositProvider that fired
after the faucet, and the one-click Start Trading CTA. The CTA now shows an
editable amount field (prefilled with the suggested default once the wallet
balance resolves, clamped to balance, user edits win), and the silent
provider is removed — onboarding completes through the CTA where the amount
is always visible and editable. Faucet modal copy updated to match.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
percolator-launch Ready Ready Preview, Comment Jul 15, 2026 10:58am
percolator-mainnet Ready Ready Preview, Comment Jul 15, 2026 10:58am
percolator-playground Error Error Jul 15, 2026 10:58am

Request Review

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9af92504-16a7-4f83-a997-04ea47bca214

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/deposit-user-chosen

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dcccrypto
dcccrypto merged commit c626d4e into playground Jul 15, 2026
13 of 14 checks passed
@dcccrypto
dcccrypto deleted the fix/deposit-user-chosen branch July 15, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant