ci(sdk-smoke): pin the nightly to the published v17 SDK 4.3.0 (fixes #389)

[dcccrypto]

Fixes #389.

The failure

The nightly SDK publish smoke has failed every night since at least 23 July — 6 consecutive runs, all schedule on main:

❯ tests/sdk-smoke.test.ts (42 tests | 15 failed)
TypeError: Cannot read properties of undefined (reading 'FeeSweep')
AssertionError: expected 'undefined' to be 'function'
@percolatorct/sdk@2.0.5 smoke FAILED

CrankAction is undefined and the v17 helpers are missing, because the job pinned SDK_VERSION: "2.0.5" while tests/sdk-smoke.test.ts targets the v17 API surface.

Why it is fixable now

#389 recorded this as blocked — "tests target v17 SDK 3.0.0, which was never published (latest npm is 2.0.9)". That premise has expired. npm view @percolatorct/sdk versions now returns:

2.0.3 … 2.0.9, 4.3.0

4.3.0 is published (percolator-launch already installs it from npm instead of a pinned git SHA), so the smoke job finally has a real published v17 version to validate against.

Verification — checked before touching CI, not after

Installed @percolatorct/sdk@4.3.0 from npm into a scratch project and ran the smoke file against it:

Test Files  1 passed (1)
     Tests  42 passed (42)

versus 15 failures on the pinned 2.0.5. So this turns the nightly green and makes it actually validate the version the keeper depends on, instead of a pre-v17 artefact.

Scope

Two lines: the SDK_VERSION env default and the job-name fallback. The 2.0.5 on line 28 is deliberately left — it is a repository_dispatch usage example in a comment, not a live default.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Chores
  • Updated SDK smoke-test validation to use SDK version 4.3.0 by default.
  • Updated workflow output to accurately display the selected SDK version.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4a872949-5c0c-4cc4-9c62-566ed480f8e5

📥 Commits

Reviewing files that changed from the base of the PR and between 0817b66 and 7cc4118.

📒 Files selected for processing (1)

• .github/workflows/sdk-smoke.yml

---

📝 Walkthrough

Walkthrough

The SDK smoke-test workflow’s default SDK version and displayed fallback version were updated from 2.0.5 to 4.3.0.

Changes

SDK smoke version update

Layer / File(s)	Summary
Update SDK version defaults .github/workflows/sdk-smoke.yml	The workflow environment default and smoke job name fallback now use SDK version 4.3.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly states the SDK smoke workflow is being pinned to 4.3.0 and references the linked fix.
Linked Issues check	✅ Passed	The workflow now uses the published v17-compatible SDK pin requested by #389, matching the issue's main requirement.
Out of Scope Changes check	✅ Passed	The only changes are the SDK version default and its job-name fallback, so nothing appears unrelated to #389.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/389-sdk-smoke-pin-4.3.0

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}