fix(api): scope DB stale-fallback cache keys by network [BUG-006]

[Morenikeoa]

Problem

withDbCacheFallback's dbCache Map (src/middleware/db-cache-fallback.ts) is keyed by the bare strings each route passes in — "markets:all", "markets:stats", "crank:status", "prices:markets", "funding:global", "stats:platform" — with no network dimension. Every live query these routes run already filters .eq("network", getNetwork()), but the fallback cache entry itself carries no record of which network's data it holds.

Impact

If the configured network changes between the call that successfully populated a cache entry and a later call that fails (a redeploy, a config flip, or any shared-DB deployment serving multiple networks from the same process over its lifetime), withDbCacheFallback would serve the previously-cached network's data under the new network's request — a 200 response silently carrying the wrong network's markets/stats/funding data, with no way for the caller to detect the mismatch.

Fix

Suffix the internal cache key with getNetwork() inside withDbCacheFallback itself (one line, applied transparently): `${cacheKey}:${getNetwork()}`. This fixes it once at the shared-utility level rather than touching all 6 call sites individually — every current and future caller gets network-scoped fallback caching automatically without needing to remember to include it themselves.

Proof of Fix

New test: seeds the cache while getNetwork() returns "devnet", then switches to "mainnet" and fails the live query under the same bare cache key. Asserts a clean 503 (no usable cache for the new network) rather than a 200 silently serving devnet's stale data.

Verified this is a genuine regression test: reverted just the source change and reran — failed with the response actually being a 200 carrying { network: "devnet-data" } under the mainnet request, exactly the bug. Restored the fix and it correctly returns 503.

• All existing tests pass — output attached.
• New regression test passes against the fix, fails against pre-fix code (verified locally).
• tsc --noEmit clean (no separate lint script in this repo).

Test Output

✓ tests/middleware/db-cache-fallback.test.ts (4 tests) 67ms

Full suite: 295/296 passed (294 baseline + 1 new). The 1 failure (tests/sdk-smoke.test.ts) is pre-existing and unrelated — it asserts on an exact @percolatorct/sdk error-message string that has drifted from the locally-resolved SDK version in this environment.

Related

Found during a broader API audit; no existing open issue/PR covers this specific cache (distinct from #192/#199/PR #204, which address live-query and view-level network isolation, not this stale-fallback cache).

[vercel]

@Princessdada is attempting to deploy a commit to the Khubair Nasir's projects Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Warning

Review limit reached

@Morenikeoa, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 44 minutes and 42 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 63723051-3a38-44e0-b7c6-7490f391c3b5

📥 Commits

Reviewing files that changed from the base of the PR and between b2751f4 and d5e8200.

📒 Files selected for processing (2)

• src/middleware/db-cache-fallback.ts
• tests/middleware/db-cache-fallback.test.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}