Repository navigation
dbeaver/pro#11110 Synchronize shared projects across desktops - #42919
serge-rider merged 19 commits into
Conversation
…tadam-add-websocket-shared-projects-events
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 191 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f653fe064
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 770ad91477
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 770ad91477
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…tadam-add-websocket-shared-projects-events # Conflicts: # plugins/org.jkiss.dbeaver.model.datadam/src/org/jkiss/dbeaver/model/datadam/rpc/DDRemoteDamDesktopSessionService.java # plugins/org.jkiss.dbeaver.ui.datadam/src/org/jkiss/dbeaver/ui/datadam/DDSyncPreferencePage.java # plugins/org.jkiss.dbeaver.ui.datadam/src/org/jkiss/dbeaver/ui/datadam/internal/DDTrackingUIMessages_pl.properties
…red-projects-events
Closes dbeaver/pro#11110
The desktop registers shared-project RPC only when its per-Dam
projects.streamSyncsetting is enabled. On registration it reconciles projects visible to the current account after the workbench opens; events received during that pass are buffered. Disabling the setting drops new events without cancelling work already in progress.Metadata events are logged instead of triggering another fetch because metadata is loaded on demand. A failed or cancelled initial reconciliation still releases buffered events and is not retried automatically.
Depends on dbeaver/datadam-api#46 for the event contract and dbeaver/datadam#256 for publication and settings delivery.