Skip to content

dbeaver/pro#11110 Synchronize shared projects across desktops - #42919

Merged
serge-rider merged 19 commits into
develfrom
dbeaver/pro#11110-datadam-add-websocket-shared-projects-events
Nov 18, 2026
Merged

serge-rider merged 19 commits into
develfrom
dbeaver/pro#11110-datadam-add-websocket-shared-projects-events

Conversation

@SolovevAnton

Copy link
Copy Markdown
Member

Closes dbeaver/pro#11110

The desktop registers shared-project RPC only when its per-Dam projects.streamSync setting is enabled. On registration it reconciles projects visible to the current account after the workbench opens; events received during that pass are buffered. Disabling the setting drops new events without cancelling work already in progress.

Metadata events are logged instead of triggering another fetch because metadata is loaded on demand. A failed or cancelled initial reconciliation still releases buffered events and is not retried automatically.

Depends on dbeaver/datadam-api#46 for the event contract and dbeaver/datadam#256 for publication and settings delivery.

@SolovevAnton

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T09:27:04.199911Z 0c93e1f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codacy-production

codacy-production Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 191 complexity

Metric Results
Complexity 191

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6f653fe064

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SolovevAnton

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 770ad91477

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@serge-rider

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 770ad91477

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SolovevAnton

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 0c93e1fe8a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

SolovevAnton and others added 2 commits November 18, 2026 10:42
…tadam-add-websocket-shared-projects-events

# Conflicts:
#	plugins/org.jkiss.dbeaver.model.datadam/src/org/jkiss/dbeaver/model/datadam/rpc/DDRemoteDamDesktopSessionService.java
#	plugins/org.jkiss.dbeaver.ui.datadam/src/org/jkiss/dbeaver/ui/datadam/DDSyncPreferencePage.java
#	plugins/org.jkiss.dbeaver.ui.datadam/src/org/jkiss/dbeaver/ui/datadam/internal/DDTrackingUIMessages_pl.properties
@serge-rider
serge-rider merged commit 435d015 into devel Nov 18, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants