Skip to content

dbeaver/pro#11726 Add optional MCP function annotations to API - #45

Merged
serge-rider merged 1 commit into
develfrom
dbeaver/pro#11726-mcp-tool-annotations
Nov 17, 2026
Merged

serge-rider merged 1 commit into
develfrom
dbeaver/pro#11726-mcp-tool-annotations

Conversation

@serge-rider

@serge-rider serge-rider commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Closes dbeaver/pro#11726

Summary

Add optional standard MCP hints to function descriptors so desktop DAMs and DataDam can exchange tool behavior metadata, including explicit false values.

Architecture

The architecture is unchanged. The shared MCP API remains the contract between function providers and consumers.

flowchart LR
    P[Function provider - unchanged] -->|describes tools| D[DDMcpFunctionDescriptor - changed]
    D -->|serialized metadata| C[Function consumer - unchanged]
Loading

Entities and relationships

Entity Change Relationships
DDMcpFunctionDescriptor Adds nullable readOnlyHint, destructiveHint, and idempotentHint fields Each descriptor retains its existing parameter list; hints describe that function

Core changes

The public com.dbeaver.datadam.mcp.api contract gains three optional fields. The existing four-argument constructor remains available. Missing hints remain null, leaving MCP defaults to consumers. Contract tests cover legacy descriptors, partial annotations, and explicit false values.

Validation

  • DDMcpFunctionContractTest: 5 tests passed in the DataDam aggregate reactor.
  • IDE build and git diff --check passed.

AI-assisted implementation using OpenCode.

Related PRs

Merge this shared API change before its consumers.

@serge-rider

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T12:05:11.493899Z 86287ea Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 86287ea680

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@serge-rider
serge-rider merged commit ba60ad7 into devel Nov 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant