Repository navigation
dbeaver/pro#11726 Add optional MCP function annotations to API - #45
Merged
Merged
Conversation
Member
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes dbeaver/pro#11726
Summary
Add optional standard MCP hints to function descriptors so desktop DAMs and DataDam can exchange tool behavior metadata, including explicit false values.
Architecture
The architecture is unchanged. The shared MCP API remains the contract between function providers and consumers.
flowchart LR P[Function provider - unchanged] -->|describes tools| D[DDMcpFunctionDescriptor - changed] D -->|serialized metadata| C[Function consumer - unchanged]Entities and relationships
Core changes
The public com.dbeaver.datadam.mcp.api contract gains three optional fields. The existing four-argument constructor remains available. Missing hints remain null, leaving MCP defaults to consumers. Contract tests cover legacy descriptors, partial annotations, and explicit false values.
Validation
AI-assisted implementation using OpenCode.
Related PRs
Merge this shared API change before its consumers.