Skip to content

dbeaver/pro#11719: fix node traversal functions - #44

Closed
SolovevAnton wants to merge 2 commits into
develfrom
dbeaver/pro#11719-datadam-mcp-fix-update-functions
Closed

SolovevAnton wants to merge 2 commits into
develfrom
dbeaver/pro#11719-datadam-mcp-fix-update-functions

Conversation

@SolovevAnton

Copy link
Copy Markdown
Member

Closes dbeaver/pro#11719

Function failures previously lost their underlying cause when wrapped as DDMcpFunctionException. The new constructor retains that cause for diagnosis without placing exception details in the MCP error data.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the cause-preserving exception constructor change.

No open issues 🎉

What changed in this PR

Adds cause-preserving exception construction to the DataDam MCP API, allowing underlying function failures to be diagnosed without adding exception details to MCP error data.

Changes:

  • Adds a DDMcpFunctionException constructor accepting a nullable cause.
  • Delegates the existing constructor to the new overload, preserving its signature.
File Description
apis/​com.dbeaver.datadam.mcp.api/​src/​main/​java/​com/​dbeaver/​datadam/​mcp/​api/​exception/​DDMcpFunctionException.java Adds cause support while leaving error code and data handling unchanged.

Review effort: Balanced

@SolovevAnton

Copy link
Copy Markdown
Member Author

closed as part of: https://github.com/dbeaver/pro/issues/11781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants