Repository navigation
dbeaver/pro#11719: fix node traversal functions - #44
Closed
SolovevAnton wants to merge 2 commits into
Closed
SolovevAnton wants to merge 2 commits into
SolovevAnton wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the cause-preserving exception constructor change.
No open issues 🎉
What changed in this PR
Adds cause-preserving exception construction to the DataDam MCP API, allowing underlying function failures to be diagnosed without adding exception details to MCP error data.
Changes:
- Adds a
DDMcpFunctionExceptionconstructor accepting a nullable cause. - Delegates the existing constructor to the new overload, preserving its signature.
| File | Description |
|---|---|
| apis/com.dbeaver.datadam.mcp.api/src/main/java/com/dbeaver/datadam/mcp/api/exception/DDMcpFunctionException.java | Adds cause support while leaving error code and data handling unchanged. |
Review effort: Balanced
Member
Author
|
closed as part of: https://github.com/dbeaver/pro/issues/11781 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes dbeaver/pro#11719
Function failures previously lost their underlying cause when wrapped as
DDMcpFunctionException. The new constructor retains that cause for diagnosis without placing exception details in the MCP error data.