Skip to content

dbeaver/pro#11680 Use checked exceptions for SSO scopes - #41

Merged
serge-rider merged 3 commits into
develfrom
dbeaver/pro#11680-checked-datadam-exceptions
Nov 17, 2026
Merged

serge-rider merged 3 commits into
develfrom
dbeaver/pro#11680-checked-datadam-exceptions

Conversation

@serge-rider

Copy link
Copy Markdown
Member

Closes dbeaver/pro#11680

Summary

  • Declare DBException for OAuth scope parsing and formatting.
  • Update scope validation tests for checked exceptions.

Validation

  • SSO API tests passed (131 tests).
  • IDE project build passed.

Coordinate with the matching desktop client and DataDam branches: dbeaver/pro#11680-checked-datadam-exceptions.

@serge-rider

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T13:23:20.626145Z 91cef7f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a7a42321f1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@serge-rider

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 91cef7f9c3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@serge-rider

Copy link
Copy Markdown
Member Author

Merged current devel in d7e619e to align the shared parent dependency with the updated DataDam branch. This preserves the checked-scope changes and generic error message and fixes dependency resolution for companion PR dbeaver/datadam#236.

@serge-rider
serge-rider merged commit 6c5d185 into devel Nov 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants