docs: fix import example for ES 2015 at: loading-into-nodejs.md#120
Open
elizatlawy wants to merge 1 commit into
Open
docs: fix import example for ES 2015 at: loading-into-nodejs.md#120elizatlawy wants to merge 1 commit into
elizatlawy wants to merge 1 commit into
Conversation
The import as described in the documentation does not work: import AdvancedFormat from 'dayjs/plugin/advancedFormat' // ES 2015 It should be: import AdvancedFormat from 'dayjs/plugin/advancedFormat.js' // ES 2015
Member
|
Thanks, I see the related issue. Can you please provide a re-production instruction so that I can check it in depth? |
Author
|
@iamkun try to import it:
|
|
Please update the documentation to suggest using This could have saved a day of headache for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The import as described in the documentation does not work:
import AdvancedFormat from 'dayjs/plugin/advancedFormat' // ES 2015It should be:
import AdvancedFormat from 'dayjs/plugin/advancedFormat.js' // ES 2015