Repository navigation
Review: keep every finding, and print the agent's error on a failed run - #23
Merged
Merged
Conversation
Ports general-environments PRs 1238 and 1239. src/review_core, the skill copy and tests/aggregator are synced from code_review_private#27; ci/github.py, ci/history.py, cli.py and action/run-review.sh are this repository's own and taken from upstream at 15e479b2f. The 18 vo-* eval tasks and .code-review/ are updated to match. New tests on a synthetic same-lines fixture: tests/ci/test_ci_same_lines.py and tests/ci/test_cli_agent_errors.py fail to import on main and pass here.
|
Important Review skippedToo many files! This PR contains 243 files, which is 93 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to Team to raise the limit. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.
 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Custom Code Review5 findings on
What the change does
codex-ci · gpt-6-luna · effort high · Codex 0.161.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports general-environments PRs 1238 and 1239 into the public reviewer: the code review keeps every finding (findings on the same lines are grouped, not merged), and a failed run prints the agent's own error.
What changed
code_review_privatewithscripts/sync_repo.py:src/review_core(aggregator, envelope, contracts), the bundled skill copy, andtests/aggregator. The sync--checkreports no drift.src/review_core/ci/github.pyandci/history.py: one inline comment per place with a section per finding. Markers name the reviewer, an old marker without one still suppresses its quote, and the history reads each section back.src/review_core/cli.pyandaction/run-review.sh: a run whose agent exits non-zero prints the agent's own error lines, with every credential form blanked.vo-*tasks, copied from the private repository's regenerated set. They were identical on bothmains before..code-review/: this repository's own reviewer copy, with the same 23 files.Tests
tests/ci/test_ci_same_lines.py(GE'stest_ci_github.py),tests/ci/test_cli_agent_errors.py, and the syncedtests/aggregator/test_same_lines.py. Their fixture is synthetic: two findings of the shape a real trial writes, on made-up code. Onmainthe first two fail to import (posted_findingsandagent_errorsdo not exist) and pass after.tests/ci/test_github_post.py(the meta line reads "also on these lines", and the marker carries the reviewer), and the launcher'stest_integrity.pyandfake_agent.py, as in the private PR (code_review_private#27).maingives 789 passed, 40 skipped.