Skip to content

gitattributes: mark the generated team tasks - #11

Merged
davidbzyk merged 1 commit into
mainfrom
chore/mark-evals-generated
Oct 11, 2026
Merged

davidbzyk merged 1 commit into
mainfrom
chore/mark-evals-generated

Conversation

@davidbzyk

@davidbzyk davidbzyk commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

This lands before the PR that adds evals/team-tasks/. The CI review reads skip marks from the base branch, so the mark has to be on main first. evals/tasks/** is already marked, so this adds the one line.

Copilot AI balanced review requested due to automatic review settings October 11, 2026 18:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

The review reads skip marks from the base branch, so the mark lands before the pull request
that adds evals/team-tasks.
@davidbzyk
davidbzyk force-pushed the chore/mark-evals-generated branch from 7924bc8 to def77e0 Compare October 11, 2026 18:22
@davidbzyk davidbzyk changed the title gitattributes: mark the generated eval tasks gitattributes: mark the generated team tasks Oct 11, 2026
@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: fa7fcf71-bfdb-40f8-acb2-b905f4294066

📥 Commits

Reviewing files that changed from the base of the PR and between 07606bf and def77e0.


📒 Files selected for processing (1)
  • .gitattributes

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: review

🔇 Additional comments (1)
.gitattributes (1)

5-5: LGTM!



📝 Summary

Summary by CodeRabbit

  • Chores
    • Marked team task evaluation files as generated.

Walkthrough

The .gitattributes file now marks files under evals/team-tasks/** as generated.

Changes

Generated folder attributes

Layer / File(s) Summary
Mark evaluation folders as generated
.gitattributes
The file adds the linguist-generated attribute for files under evals/team-tasks/**.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other


Merge Risk: ⚪ Minimal · up to def77

The generated-file marker matches the intended folder and existing rule; no actionable merge risk remains.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: marking generated team tasks in .gitattributes.
Description check Passed The description explains the .gitattributes change and its required ordering before the PR that adds evals/team-tasks/.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

✨ Simplify code
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit hops past task files in a row
“Generated,” says the label, neat as snow
My paws leave prints, my ears stand tall
The folders wear their new tag, one and all
I nibble clover, then bound away!

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom Code Review

1 finding on def77e0 · 1 P2

codex-ci · gpt-6-luna · effort high · Codex 0.161.0

Comment thread .gitattributes
@github-actions

Copy link
Copy Markdown

Custom Code Review

1 finding on def77e0 · 1 P2

Severity Finding Where
P2 Team task exclusion lacks a regression test .gitattributes:5
What the change does
  • The change updates `.gitattributes`.
  • It adds `evals/team-tasks/**` to the paths marked `linguist-generated`.
  • The existing rules for vendored research data and generated eval tasks remain as before.

codex-ci · gpt-6-luna · effort high · Codex 0.161.0

@davidbzyk
davidbzyk merged commit cf1cacc into main Oct 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants