Spectral detection needs more than one raw detector, and the keep rule matches the detection's case - #60
Open
david-priest wants to merge 1 commit into
Open
Spectral detection needs more than one raw detector, and the keep rule matches the detection's case#60david-priest wants to merge 1 commit into
david-priest wants to merge 1 commit into
Conversation
…e matches the detection's case A conventional file with one unlabelled fluorescence channel was classified as spectral-unmixed, which dropped its -H/-W channels and changed every gate's channel identity between files of a panel that differed only in that label. The rule now needs more than one raw detector, as GateLab's channels.ts does. The keep rule tested the "-A" suffix case-sensitively while the detection did not, so a marker written "-a" made the file unmixed and was then dropped. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups to #56, mirroring GateLab-dev #198 so the R app and the browser classify a file the same way.
More than one raw detector. A conventional file with a single unlabelled fluorescence channel — an unstained or spare detector — satisfied "at least one raw detector" and was classified as spectral-unmixed, which dropped its
-H/-Wchannels and changed every gate's channel identity between files of one panel that differed only in that label. The rule now needs more than one raw detector; a spectral file carries dozens.The keep rule matches the detection's case. Detection tested the
-Asuffix case-insensitively, the keep rule did not, so a marker written-acounted towards making the file unmixed and then fell through to the drop branch, losing the channel.Tests: two raw detectors still trigger filtering (and a
-amarker survives it); one unlabelled channel keeps a conventional file whole.Finding 14 of the 2026-09-11 review of the wsp-testing PRs.
🤖 Generated with Claude Code