add training data for some state of utah address anomalys#399
Open
stdavis wants to merge 2 commits intodatamade:mainfrom
Open
add training data for some state of utah address anomalys#399stdavis wants to merge 2 commits intodatamade:mainfrom
stdavis wants to merge 2 commits intodatamade:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds training data to improve address parsing for Utah-specific address anomalies, incorporating patterns from the state's address point layer to benefit the broader community.
- Adds 34 new training examples in
labeled.xmlcovering numeric street names, directional variations, and unit identifiers - Updates one existing test case to correct address number suffix tagging
- Adds 14 new test cases to validate the training improvements
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| training/labeled.xml | Adds Utah-specific training examples for numeric streets, directional patterns, city names, and address suffixes |
| measure_performance/test_data/labeled.xml | Corrects one existing address tagging and adds test cases for the new training patterns |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for some address issues that we have experienced in the state of Utah. We have used our fork of this repo for years. However, after seeing some recent activity in this project, we'd love to incorporate our data into it for the benefit of everyone.
Specifically this improves the tagging of cities, numeric road names, and unit numbers that we have found in our statewide address point layer.