Conversation
Contributor
Author
|
@derekeder I've got testing/training data from all the older prs that were still open into this one as well (all noted in the description), so this'll bring a whole swath of updates when it's brought in. |
derekeder
approved these changes
May 2, 2025
Member
derekeder
left a comment
There was a problem hiding this comment.
nice! instructions work locally for me, test addresses work as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This adds some of the highway contract route addresses, county roads, directional placenames, and addresses without streetnameposttypes found in prs #258, #259, #251, and #222 to the testing/training data (shoutouts to @bbharathrao, @rptetzloff, and @ecatkins). I'm opening a new pr instead of adding those mostly because of the new testing suite that comes with prs here nowadays, and the new way in which we're adding data to the one file instead of having multiple files.
Labelling for HCR boxes should look like:
('235', 'USPSBoxGroupID'),
('Box', 'USPSBoxType'),
('1A', 'USPSBoxID')
Labelling for county roads should look like:
('Rd', 'StreetNamePreType'),
('MM,', 'StreetName'),
('Granada,', 'PlaceName'),
('CO', 'StateName')
Labelling for directional placenames without streetnameposttypes look like:
('NE', 'StreetNamePreDirectional'),
('4th', 'StreetName'),
('Fort', 'PlaceName'),
('Lauderdale,', 'PlaceName'),
('FL', 'StateName')
Testing
HC 267 Box 22Highway contract Rte 1 Box 77Z