Repository navigation
Add DataHub-styled React visualizations with validated chart intents - #100
Open
shirshanka wants to merge 2 commits into
Open
shirshanka wants to merge 2 commits into
shirshanka wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce a React visualization catalog built with visx and a local adapter of DataHub Alchemy colors. The chart model selects a versioned intent and column roles; the backend validates it and binds the full query/tool result. Both automatic SQL charts and
create_chartuse this path.Included
/charts.html, contract documentation, and CI coverage for the new frontend tests.This uses local Alchemy color tokens, not a new published Alchemy dependency. Trend categories are equally spaced in SQL result order; the renderer does not infer continuous time intervals or aggregate data.
Verification
Known verification limits
buildUiMessages.test.tstestattaches USAGE to the previous TOOL_CALL in resultfails against unchanged implementation/test files. This PR adds an explicit CI step for the new visualization suite; it does not suppress or modify that existing test.Preview locally
pnpm --dir frontend install --frozen-lockfile pnpm --dir frontend dev --host 127.0.0.1 --port 5187 # Open http://127.0.0.1:5187/charts.htmlSee
docs/visualizations.mdfor the schema, supported forms, limits, and compatibility behavior.